Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Titlebar is always dimmed on Qt5 Wayland #125

Closed
Eloston opened this issue Dec 16, 2022 · 2 comments · Fixed by #126
Closed

Titlebar is always dimmed on Qt5 Wayland #125

Eloston opened this issue Dec 16, 2022 · 2 comments · Fixed by #126

Comments

@Eloston
Copy link

Eloston commented Dec 16, 2022

Not sure if this is a known issue, but here we are.

Because of 6a3e8ff, Qt5 applications running on Wayland will always have their titlebar in an inactive/unfocused state. Reverting this commit seems to restore the correct behavior.

Environment:

  • Debian 11 (Qt 5.15.2)
  • adwaita-qt 1.4.2
@grulja
Copy link
Collaborator

grulja commented Dec 17, 2022

cc: @polter-rnd

@polter-rnd
Copy link
Contributor

Looks like it's because 6a3e8ff was aimed on Fedora-patched Qt and works incorrectly on vanilla 5.15.2 (which did not have that problem with titlebar dimming originally), sorry. I will look in detail later, will try to fix for both

polter-rnd added a commit to polter-rnd/QGnomePlatform that referenced this issue Dec 28, 2022
@polter-rnd
Fix regression in rendering titlebar on vanilla Qt
818420d 
Don't use `window()->windowStates()` for checking active window state
on vanilla Qt5, this works only on Qt6 or with KDE's patchset for Qt5.

Fixes FedoraQt#125

Signed-off-by: Pavel Artsishevsky <[email protected]>
@polter-rnd polter-rnd mentioned this issue Dec 28, 2022
Merged
grulja pushed a commit that referenced this issue Jan 2, 2023
@polter-rnd
Fix regression in rendering titlebar on vanilla Qt (#126)
ba82069 
Don't use `window()->windowStates()` for checking active window state
on vanilla Qt5, this works only on Qt6 or with KDE's patchset for Qt5.

Fixes #125

Signed-off-by: Pavel Artsishevsky <[email protected]>

Signed-off-by: Pavel Artsishevsky <[email protected]>
grulja pushed a commit that referenced this issue Mar 7, 2023
@polter-rnd @grulja
Fix regression in rendering titlebar on vanilla Qt (#126)
3334ecc 
Don't use `window()->windowStates()` for checking active window state
on vanilla Qt5, this works only on Qt6 or with KDE's patchset for Qt5.

Fixes #125

Signed-off-by: Pavel Artsishevsky <[email protected]>

Signed-off-by: Pavel Artsishevsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression in rendering titlebar on vanilla Qt polter-rnd/QGnomePlatform
3 participants
@grulja @Eloston @polter-rnd