test(index): tidy up

Fdawgs · Mar 12, 2024 · 1960f47 · 1960f47
1 parent a7319f6
commit 1960f47
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/index.js b/src/index.js
@@ -92,7 +92,11 @@ class Poppler {
 	 * if a local installation is not found.
 	 */
 	constructor(binPath) {
+		this.popplerPath = "";
+
+		/* istanbul ignore else: requires specific OS */
 		if (binPath) {
+			/** @type {string|undefined} */
 			this.popplerPath = binPath;
 		} else {
 			const { platform } = process;

diff --git a/src/index.test.js b/src/index.test.js
@@ -73,15 +73,6 @@ describe("Node-Poppler module", () => {
 			});
 		});
 
-		it("Creates a new Poppler instance without the binary path set on win32", () => {
-			Object.defineProperty(process, "platform", {
-				value: "win32",
-			});
-
-			const poppler = new Poppler();
-			expect(poppler.popplerPath).toBe(windowsPath);
-		});
-
 		/**
 		 * @todo Fix this test, mocking of "node:" scheme not supported yet.
 		 * @see {@link https://github.com/jestjs/jest/pull/14297 | Jest PR #14297}