Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix REPLACE_PERSISTENT_COLLECTIONS in EAGER #146

Closed
wants to merge 3 commits into from

Conversation

pses
Copy link

@pses pses commented Dec 1, 2021

issue #140

@cowtowncoder
Copy link
Member

Apologies for slow follow up here.

Looks good in general, thank you very much for submitting it!

Couple of small things:

  1. Would it make sense to add this in 2.13 branch, to be included in 2.13.2 (master is for upcoming 2.14.0)
  2. There are 3 modules (hibernate4, hibernate5, hibernate5-jakarta), so changes need to be added to the other 2

It would also be great to have a reproduction (unit test), although I don't know how easy it'd be to create one.

Also: once this is ready for merge to the right branch, I would need a CLA (unless I have received one before -- if you have sent one let me know). It's here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print the 1-page doc, fill & sign it, scan/take photo, email to info at fasterxml dot com.
Once I receive it I can merge PR and CLA is good for any other contributions as well (so it's one time thing before the first contribution).

@cowtowncoder
Copy link
Member

Would still be great to get this in....

dinerotah added a commit to dinerotah/jackson-datatype-hibernate that referenced this pull request May 2, 2023
fix REPLACE_PERSISTENT_COLLECTIONS in EAGER FasterXML#146
@pjfanning
Copy link
Member

@pses would you be interested in still getting this merged? If not, would be willing to put this code in the public domain so other users could work on getting it merged? For context, see #173.

cowtowncoder pushed a commit that referenced this pull request Jun 6, 2023
fix REPLACE_PERSISTENT_COLLECTIONS in EAGER #146
@cowtowncoder
Copy link
Member

Replaced by #173, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants