Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Evolves the rules engine to a non-generic version by setting the content type and condition type to a string default. The library users can optionally use a generic rules engine wrapper specifying
TContentType
andTConditionType
- as long as those types are either enum types or other types convertible to string and parseable from string.Warning
Breaking change on rules engine build-up. Current usages of the library will have to remove
TContentType
andTConditionType
from builder methods and use and additionalMakeGeneric<TContentType, TConditionType>()
method to get a equivalent instance of RulesEngine<TContentType
,TConditionType
>.Warning
Additional APIs were added to create and get content types from the rules engine.
From now on, the library users will be required to create explicitly the content types using the new API, except if the
AutoCreateContentTypes
option is true.This is a breaking change on behavior.
Change checklist
Please also check the I want to contribute guidelines and make sure you have done accordingly.
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement