Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created ManualControl Class for easy testing #94

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

BolunDai0216
Copy link
Collaborator

Description

Change the manual control script to include a ManualControl class which can be easily used with unregistered environments.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is functionally identical to the old version that is good with me

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit 030ba7c into Farama-Foundation:master Apr 19, 2023
@BolunDai0216
Copy link
Collaborator Author

If this is functionally identical to the old version that is good with me

I just wrapped manual control functionalities of the previous code into a class, and moved the command line argument parser into the main function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants