Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AgileRL and TorchRL smoke tests #196

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Conversation

cmmcirvin
Copy link
Contributor

Description

Added smoke tests for AgileRL and TorchRL, two libraries that make use of Minari

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@younik
Copy link
Member

younik commented Mar 6, 2024

Hey @cmmcirvin, thank you for the PR!
Can you add torchrl and agilerl as dependencies under testing?

Minari/pyproject.toml

Lines 41 to 45 in 9803a70

testing = [
"pytest>=7.1.3",
"gymnasium-robotics>=1.2.3",
"mktestdocs"
]

@cmmcirvin
Copy link
Contributor Author

Added the dependencies.

Copy link
Member

@younik younik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@younik younik merged commit 73e7711 into Farama-Foundation:main Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants