attempted to fix list_remote_datasets slowdown #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix the slowdown to
list_remote_datasets
introduced in 0.4.0.0.4.1 average runtime: 3.2189864999999998
0.3.1 average runtime: average runtime: 0.2429087
patched version: average runtime: 0.7913758999999999
n=20
I will also re-run this profiling with n=100 prior to marking this ready for review, since the Google bucket response times seem to add a lot of variance.(I redid n=20 and results seem to replicate well enough I'm convinced this patch is worthwhile)Type of Change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.