Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Backslots to Sec Armor and Whatever Else I Added It To #545

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

VividPups
Copy link
Contributor

Backslot added back

Description

highly request People who want to get their backshots I mean slots back

Changelog

🆑

  • add: add blackslot back to all security armor

Backslot added back
@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: YML Changes any yml files and removed Status: Needs Review Someone please review this labels Feb 11, 2025
@Floof-Station-Bot Floof-Station-Bot changed the title Adds Backslots to sec armor and whatever else i added it to Adds Backslots to Sec Armor and Whatever Else I Added It To Feb 11, 2025
@ProphetCrow
Copy link
Contributor

ProphetCrow commented Feb 11, 2025

suggest to also include clothingouterwintersec as its an armored coat that is a popular choice on stations like glacier
image

and by extension, the security sweater since its spawns in secoff lockers.
image

@FoxxoTrystan FoxxoTrystan self-assigned this Feb 11, 2025
@FoxxoTrystan FoxxoTrystan added the Priority: 2-Medium Needs to be resolved at some point label Feb 11, 2025
Copy link
Collaborator

@Mnemotechnician Mnemotechnician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use entity parenting, but in a different way - adding suit storage slots to base coats/suits instead of editing the parents of each induvidual coat/suit. More coats may be added in the future, and those changes won't be reflected in them if this PR is merged as-is.

@VividPups
Copy link
Contributor Author

This should use entity parenting, but in a different way - adding suit storage slots to base coats/suits instead of editing the parents of each induvidual coat/suit. More coats may be added in the future, and those changes won't be reflected in them if this PR is merged as-is.

Well from what I saw the way I added was because the blackslot storage itself a parent (which i thought was kinda of odd)

@Mnemotechnician
Copy link
Collaborator

Well from what I saw the way I added was because the blackslot storage itself a parent (which i thought was kinda of odd)

That is the correct way, but where you added it is incorrect. You should add the parent to ClothingOuterArmorBasic and other similar base prototypes instead of editing every single armor piece that is a child of it. Likewise, you should add the parent to ClothingOuterWinterCoat instead of editing every single winter coat.

revert to OG
@VividPups
Copy link
Contributor Author

image
this is waht happens when i added to the based

update
aaaaa
i tested it on multiple winter coats and armors
@VividPups
Copy link
Contributor Author

Tested multiple different Winter coats, armors and jackets all of them accepted an weapon. this was tested As a human

Copy link
Collaborator

@Mnemotechnician Mnemotechnician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will do, but you really just added suit storage slots to all outer clothing, including jackets and the like. I don't think it will be a major issue, though.

added the container and sound as requested
@FoxxoTrystan FoxxoTrystan self-requested a review February 22, 2025 20:39
@Memeji Memeji merged commit 4cdaa97 into Fansana:master Feb 24, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files Priority: 2-Medium Needs to be resolved at some point Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants