fix: Fix bug resulting from single queue in Dispatch (#365) #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderGugel
force-pushed
the
Dispatch-quick-fix
branch
2 times, most recently
from
2a8341e to
6384522
Compare
|
@alexanderGugel do you have a example of the bug? |
alexanderGugel
force-pushed
the
Dispatch-quick-fix
branch
from
cf0dcfd to
588068e
Compare
|
@michaelobriena Added additional test case to cover the previous bug. |
alexanderGugel
force-pushed
the
Dispatch-quick-fix
branch
from
588068e to
c5281aa
Compare
|
@michaelobriena Rebased. The added test case covers the bug. #365 includes detailed bug report. |
alexanderGugel
force-pushed
the
Dispatch-quick-fix
branch
from
cbe0e91 to
6224618
Compare
|
landed as 6224618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365
Currently doesn't reuse queue, but correctly handles events being emitted during propagation of old event.