fix: No longer access Scene#_selector

Famous · Jul 21, 2015 · 813da13 · 813da13
1 parent 9772baf
commit 813da13
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/FamousEngine.js b/core/FamousEngine.js
@@ -405,7 +405,7 @@ FamousEngine.prototype.addScene = function addScene (scene) {
  * @return {FamousEngine} this
  */
 FamousEngine.prototype.removeScene = function removeScene (scene) {
-    var selector = scene._selector;
+    var selector = scene._id;
 
     var current = this._scenes[selector];
     if (current && current === scene) {

diff --git a/core/Scene.js b/core/Scene.js
@@ -53,6 +53,7 @@ Scene.NO_DEFAULT_COMPONENTS = true;
  * Returns the selector that the context was instantiated with
  *
  * @return {String} dom selector
+ * @deprecated
  */
 Scene.prototype.getSelector = function getSelector () {
     console.warn('Scene#getSelector is deprecated, use Scene#getLocation or Scene#getId instead');