Fail test when calling function twice #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the Initialize function such that it asserts when the function is called twice.
Comment on lines
+81
to
84
| fIsInitialised = kTRUE; | ||
| /* | ||
| FairRuntimeDb* rtdb= FairRun::Instance()->GetRuntimeDb(); | ||
| FairTutorialDet1GeoPar* par=(FairTutorialDet1GeoPar*)(rtdb->getContainer("FairTutorialDet1GeoPar")); |
There was a problem hiding this comment.
Maybe remove the commented code while you're changing this anyway?
ChristianTackeGSI
approved these changes
Jun 7, 2022
| @@ -95,6 +95,8 @@ class FairTutorialDet1 : public FairDetector | |||
| Double32_t fLength; //! length | |||
| Double32_t fELoss; //! energy loss | |||
|
|
|||
| Bool_t fIsInitialised; //! prevent double initilization | |||
There was a problem hiding this comment.
Suggested change
| Bool_t fIsInitialised; //! prevent double initilization | |
| bool fIsInitialised{false}; //!< prevent double initilization |
Some ideas:
- Let's use plain C++ types (
bool) - member initaliser?
- Doxygen compatible comment
There was a problem hiding this comment.
the ideas are fine but I would prefer to move the PR as is.
I also thought about them but in my opinion this should be done in separate pull requests which move the code to more modern C++.
There was a problem hiding this comment.
Then go ahead and merge this one!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Initialize function such that it asserts when the function is
called twice.
Closes #1195
Checklist:
devbranch