-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug ems #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
k-rieck
commented
Mar 19, 2024
- rename ems outputs and inputs
- use more default connections
…ependency of each component
noah80
approved these changes
Apr 15, 2024
noah80
added a commit
that referenced
this pull request
Apr 16, 2024
* specify pv production in kpis * fix pytest electricity meter * fix kpi error due to error in postprocessingflag of hp hplib thermal power * fix pytest builing sizer pp-option * add some of new kpis to scneario processing list * small fix * remove rounding in electricity meter * enable heating by devices * chaanges on building * smaller changes * add stacked bar plot and flow and return temps in kpis and scenario evaluation * order bar plots * fix mypy * prospector * try to fix tests * more explanation for heating test * fix pytests and prospector * fix rounding error in kpis * add some building kpis * add some more building outputs * add more outputs and kpis for building for testing purposes * small change * plotting improvement * sort kpis * fix pytest electricity meter * implement hds flow and return temperatures as kpis * some important changes * more change * use ems and battery only when pv is used in cluster system setup * some more dev on scenario evaluation * make tofromgrid output in Wh for em * fix pytest * fix pytest * fix pylint * keep electricity availabe in watt * code qualy * add some more inputs to advanced hp for cooling validation * add some more hplib kpis * fix hplib test * add some more hplib kpis * fix pytest * fix pytest * fix pylint * make cluster system setup run * code qualy * some more changes * some more changes * save x_y_plot_data * small improvement in plotting * slight changes on scenario evaluation * Add files via upload * Debug ems (#326) * ems renaming variables * use more default connections for ems * use more default connections for ems * some more renaming * some more cleaning up ems * more tidying up and chnages on ems outputs, try to investiagte grid dependency of each component * fix pytest * some more renaming * some more renaming * some more renaming * Windturbine and additional parameters/function in weather modell (#277) * more advanced heat pump model, example and tester * tester for more advanced heatpump * units for pressure todo: automatische änderung bei plots von hPa in bar etc. * weather model ergänzt um druck aus-/übergabe * model ergänzt um druck für ggf zukünftige erweiterung von windkraftanlage modell * pressure output angepasst * pressure ergänzt * anpassen auf SI-Einheit für Druck * anpassen auf SI-Einheit für Druck * anpassen auf SI-Einheit für Druck * modell ergänzt um pressure output für windkraftanlage, vorbereitung funktion zum beziehen von wetterdaten vom dwd (10min aflösung) durch extra modell --> aktuelle reale wetterdaten für ein jahr * test * wettermodell update * hisim uodate * wp modell nicht für diesen Branche! Hier nur Windkraft und wetter * New Modell of a Windturbine based on windpowerlib https://github.com/wind-python/windpowerlib/tree/dev * test for generic windturbine * gehört nicht zum branche für windkraftanlage * manuell auf aktuelle hisim version kopiert * erst zu mein branche, wenn komplett fertig und abgenommen * - implement windpowerlib in requirements.txt - fix pytest issues * - Preparation for external weather data retrieval of DWD and era5 data - Function for era5 data added - function for dwd retrieval corrected - variables and function renamed for better overview (DWD to DWD_TRY) --> Script for data retrieval from dwd/era5 database will follow after consultation * geändert auf original weather model * NOTE: NEW MODEL FOR WEATHER DATA IMPORT (weather_data_import.py) --> PLEASE CHECK ALSO FOR MERGING - fixing testing issues - implement new test setups for data request - add new python lib to test/requirement files * a small change to make the variable "name" flexible --> "name" is now specified in the config class. Enables the integration of several weather objects in the simulation (particularly helpful for wind turbine applications, as they often have a different location than buildings) * update and fix merge conflicts * - updated nsrdb_15min files: parameter "pressure" and "wind direction" were added due to new parameters in weather.py model (error with "old" files due to missing parameters if using nsrdb_15min) - todo: push branch again when "Fix utsp tests" is merged into main to pass tests --------- Co-authored-by: noah80 <[email protected]> Co-authored-by: Hoppe-J <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.