more advanced heatpump with outputs for dhw and building heating #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo: automatische änderung bei plots von hPa in bar etc.
vorbereitung funktion zum beziehen von wetterdaten vom dwd (10min aflösung) durch extra modell --> aktuelle reale wetterdaten für ein jahr
comment: model actual doesn't work with regulated generic model --> maybe problem with hpLib todo: implement caching
# Conflicts: # hisim/sim_repository_singleton.py
…th example "household_1"
…unction) --> caching leads to convergence errors???
-set hp parameters (model/manufacture) in both example to stiebel wpl25 for comparison - tester for new hp - but doesn't work??
now cache function leads to convergence errors
|
Link to simulation results for comparision the "new" heatpump model vs. the heatpump system (advanced hp and dhw hp) |
…m_setup_household_1" --> now it works
… right (before electrical power of hp was too high)
# Conflicts: # hisim/components/more_advanced_heat_pump_hplib.py # system_setups/household_1_advanced_hp_diesel_car.py
|
new simulation results in https://cloud.febop.de/index.php/s/DPLfmwctXcz6493 comparison with "generic" heatpump model for (more) advanced HP |
code style and test issues will follow in next commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extended advanced heat pump model. model has two controllers for DHW and building heating with switching between them. Priority on DHW if both requirements are present at the same time