Skip to content

Commit

Permalink
fix mypy and pylint issues
Browse files Browse the repository at this point in the history
  • Loading branch information
kdabrock committed Feb 11, 2025
1 parent aa8b1cc commit 0dd8bce
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion hisim/components/generic_pv_system.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def size_pv_system(
== PVLibModuleAndInverterEnum.SANDIA_MODULE_DATABASE
):
module_area_in_m2 = 1.65
module_power_in_watt = 250
module_power_in_watt = 250.
# this is equal to an efficiency of 15,15%

elif (
Expand Down
12 changes: 6 additions & 6 deletions hisim/inputs/photovoltaic/module_selection.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# This notebook documents the selection of a default PV module and inverter
# From the CEC database
"""This notebook documents the selection of a default PV module and inverter from the CEC database"""

#%% Import CEC database file
import pandas as pd
data = pd.read_csv("data_processed/cec_modules.csv")
Expand Down Expand Up @@ -29,12 +29,12 @@
inverter_data["eff"] = inverter_data["Paco"] / inverter_data["Pdco"]

candidate_inverters = inverter_data[
(inverter_data["Pdco"].astype(float) > selected["P_max"]) &
(inverter_data["Paco"].astype(float) > 0.8 * selected["P_max"]) &
(inverter_data["Pdco"].astype(float) > selected["P_max"]) &
(inverter_data["Paco"].astype(float) > 0.8 * selected["P_max"]) &
(inverter_data["Paco"].astype(float) < 1.2 * selected["P_max"]) &
(inverter_data["Vdco"].astype(float) > 0.95 * selected["V_mp_ref"]) &
(inverter_data["Vdco"].astype(float) < 1.05 * selected["V_mp_ref"]) &
(inverter_data["Idcmax"].astype(float) > selected["I_mp_ref"])
(inverter_data["Idcmax"].astype(float) > selected["I_mp_ref"])
]

selected_inverter = candidate_inverters.sort_values(by='eff').iloc[-1]
selected_inverter = candidate_inverters.sort_values(by='eff').iloc[-1]

0 comments on commit 0dd8bce

Please sign in to comment.