ExternalProject for CMake build for Android #2050
Open
+63
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, just use included in CMake ExternalProject feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will probably resolve all issues with too complex Android build process.
So far, it gets installed into the correct folder and get packaged into APK, but binaries built with Waf are dependent on
libc++_sharedfor some reason, while ones that were using CMake doesn't. This tells me that propagating flags from CMake to Waf is important here. However, instead, I'm actually thinking of just re-using Android NDK support inxcompile.py. And then I have to fix it for Windows builds too. :)What I also don't like, is that the build directory is too far away from the source, and the compiler generates long relative paths here, i.e. what was
../public/build.cbecomes../../../../../public/build.c. I can try usingfile-prefix-mapcompiler flag here, but not sure if this will break debugging or not. It's something I will work on before this will get merged.cc @Velaron