Fixes for https://github.com/FStarLang/FStar/pull/3072 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two definitions failed after the fix in FStarLang/FStar#3072. The assertions make it work
I've seen this proof randomly regress several times, with the error:
* Error 228 at Steel.ST.Array.Util.fst(68,4-68,25):
- Tactic failed
- "apply_lemma: Cannot instantiate lemma FStar.Tactics.V2.Logic.fa_intro_lem (with postcondition: Prims.squash (forall (x: Steel.Effect.Common.vprop).
Steel.Effect.Common.equiv (Steel.Effect.Common.VStar (*?u4892*) _ (*?u4888*) _) (*?u4880*) _ ==>
(*?u4872*) _)) to match goal (Prims.squash (forall (x2: Steel.Effect.Common.vprop).
Steel.Effect.Common.equiv (Steel.Effect.Common.VStar x x2) x ==>
Steel.Effect.Common.equiv (Steel.Effect.Common.VStar x2 x)
(Steel.Effect.Common.VStar (Steel.Effect.Common.VStar Steel.Effect.Common.emp x)
Steel.Effect.Common.emp)))"
The latest one being when trying to merge the normalizer fix in
FStarLang/FStar#3072. Apparently, just adding an
extra unit makes it work, so I am just doing that to unblock the F* PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed to keep the build working after the F* PR is merged.