SMTEncoding: prevent hash inconsistencies due to filepaths #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string_of_range call in this function may depend on absolute filepaths, and be inconsistent across different systems or different F* install within a single system. Noticed this due to a failing proof in FStar.Math.Fermat. Looking at the SMT queries for runs of F* in different directories, the hashes for many Tm_refine_ terms differed. With this change, there is no difference between the two SMT2 files (modulo comments) for each run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string_of_range call in this function may depend on absolute
filepaths, and be inconsistent across different systems or different
F* install within a single system. Noticed this due to a failing proof
in FStar.Math.Fermat. Looking at the SMT queries for runs of F* in
different directories, the hashes for many Tm_refine_ terms differed.
With this change, there is no difference between the two SMT2 files
(modulo comments) for each run.