Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow one #3500

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Arrow one #3500

merged 3 commits into from
Sep 25, 2024

Conversation

mtzguido
Copy link
Member

arrow_one_ln was needlessly closing over the binders again, even though they were already closed. This is a no-op, but it makes some programs quadratic instead of linear, for instance if calling arrow_one_ln repeatedly from a tactic, which happens for collect_arr_bs, and others.

For an arrow with 500 binders and the mk_projectors tactics, this reduced the startup time from ~3s to 180ms. There's other bottlenecks probably.

@mtzguido
Copy link
Member Author

@mtzguido mtzguido merged commit 81729d0 into FStarLang:master Sep 25, 2024
2 checks passed
@mtzguido mtzguido deleted the arrow_one branch September 25, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant