Add normalization step for tactics. #3460
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1969 added normalization for impure lets in tactic execution, but this was gated on the reify step. The reify step is however also enabled in extraction, and then this heuristic can incorrectly remove effectful lets.
This PR adds a new tactics step in the normalizer, which is only enabled in tactic execution. The heuristic from #1969 is only enabled when this step is set, and no longer applies during extraction.
@mtzguido did pretty much all the work here, thank you!