Misc fixes #3235
Merged
Misc fixes #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes some test files more sensible, since errors are now reported only once.
Otherwise debug toggles do not work.
|
Got a green after removing the fix for 3234. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of them are only internal, just tidying and refactoring.
The main change here is skipping the normalization/simplification of VCs when we are not verifying the module. This saves a lot of time in some particular examples such as:
since the
norm (slow ())term appears in the VC, has to be normalized even if this is in lax mode. It is still bad that the term is duplicated, but that's for a future PR.There is also a fix for #3234.Removed as it triggers a regression in HACL* due to some functions now reducing and taking too long.Testing everest locally before merging.