fix: treat maxDiffThreshold 0 as valid value

Signed-off-by: Jakub Freisler <[email protected]>
FRSOURCE · Mar 26, 2023 · f4d3ec9 · f4d3ec9
1 parent d48fa3e
commit f4d3ec9
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/commands.ts b/src/commands.ts
@@ -75,6 +75,11 @@ const getImagesDir = (options: Cypress.MatchImageOptions) => {
 
 export const getConfig = (options: Cypress.MatchImageOptions) => {
   const imagesDir = getImagesDir(options);
+  const maxDiffThreshold =
+    options.maxDiffThreshold ??
+    (Cypress.env("pluginVisualRegressionMaxDiffThreshold") as
+      | number
+      | undefined);
 
   return {
     scaleFactor:
@@ -94,11 +99,7 @@ export const getConfig = (options: Cypress.MatchImageOptions) => {
       (Cypress.env("pluginVisualRegressionImagesPath") as string | undefined) ||
       "{spec_path}/__image_snapshots__",
     maxDiffThreshold:
-      options.maxDiffThreshold ||
-      (Cypress.env("pluginVisualRegressionMaxDiffThreshold") as
-        | number
-        | undefined) ||
-      0.01,
+      typeof maxDiffThreshold === "number" ? maxDiffThreshold : 0.01,
     diffConfig:
       options.diffConfig ||
       (Cypress.env("pluginVisualRegressionDiffConfig") as