-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation message for monitor when send string is missing #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
nandakishorepeddi
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
00337e1
to
dc913e8
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
vklohiya
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vklohiya
added a commit
that referenced
this pull request
Jun 27, 2023
* Updating the next version (#2904) * Exclude the removal of static ARP entries for Flannel CNI during CIS restart (#2905) * Updating the kubernetes support matrix (#2906) * Fix monitor not creating for VS CRD when send string is missing (#2910) * Ignore virtualservername if hostgroup configured (#2903) * Moving the node informers at appmanager level (#2902) * Fix hostless VS with IPAM to work with hostgroup (#2917) * Fix UTs (#2915) * Fix for route processing and panic handling for route status update (#2918) * Add validations for hostless VS with IPAM and hostgroup (#2922) * Fix issue of empty pool member with defaultRouteGroup (#2843) * Enbale metrics with ipv6 (#2923) * fix nodeport cccl not pushing config (#2933) * Remove path field from health monitor annotation (#2934) * Add validation message for monitor when send string is missing (#2936) * Enable tcp monitor for VS crd without send string (#2937) * Add EDNS Persistence Support (#2950) * Revert "Add EDNS Persistence Support (#2950)" (#2951) This reverts commit a021059. * Release notes 2.13.1 (#2930) --------- Co-authored-by: Arbaaz Khan <[email protected]> Co-authored-by: Nanda Kishore <[email protected]> Co-authored-by: charanm08 <[email protected]> Co-authored-by: Lavanya Sirigudi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add validation message for monitor when send string is missing
Changes Proposed in PR: Add validation message for monitor when send string is missing
Fixes: resolves #Github issue id
General Checklist
CRD Checklist