Support stereo image streaming using Deflect #629
Merged
+158
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdumusc: This needs testing. Will let you know. |
rdumusc
reviewed
Mar 22, 2017
eq/deflect/proxy.cpp
Outdated
| default: break; | ||
| } | ||
|
|
||
| _pending[_current].emplace_back( _stream->asyncSend( imageWrapper )); |
There was a problem hiding this comment.
which must be the cause of your stream closing, because then the second finishFrame happens with no data
eq/deflect/proxy.cpp
Outdated
| ~Impl() | ||
| { | ||
| // wait for completion of previous send | ||
| _sendFuture.wait(); |
There was a problem hiding this comment.
no need to wait in the destructor anymore?
eq/deflect/proxy.cpp
Outdated
| ::deflect::Stream::Future _sendFuture; | ||
| static const size_t _current = 0; | ||
| static const size_t _last = 1; | ||
| std::vector< ::deflect::Stream::Future > _pending[2]; |
There was a problem hiding this comment.
Now that there are two futures, shouldn't there be two _buffer as well? It seems to me that the current buffer could be overwritten before the last send has finished, are you sure this is not the case? Maybe even 4 buffers (2x each eye)?
eile
force-pushed
the
master
branch
4 times, most recently
from
7570cff to
1fbde01
Compare
|
RTM. Note: Streaming anaglyph stereo rendering gives undefined behaviour. Conceptually it makes no sense, since the streamed left/right images need to be complete. |
rdumusc
approved these changes
Mar 23, 2017
eile
force-pushed
the
master
branch
2 times, most recently
from
a01f8dd to
642efb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.