Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PBuffer support #602

Merged
merged 2 commits into from
Dec 22, 2016
Merged

Remove PBuffer support #602

merged 2 commits into from
Dec 22, 2016

Conversation

eile
Copy link
Member

@eile eile commented Dec 20, 2016

No description provided.

hernando
hernando reviewed Dec 20, 2016
View reviewed changes
Copy link

@hernando hernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it happen now if I pass -8 though the environmental variable to choose the drawable type?

All the config files that you have removed should be modified to use FBOs instead? Or you don't really want to keep them?

eq/server/loader.y
| EQTOKEN_PBUFFER
{
$$ = eq::fabric::FBO;
LBERROR << "Using FBO for obsolete pbuffer token" << std::endl;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"PBuffers support removed, using FBO"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@eile
Copy link
Member Author

eile commented Dec 21, 2016

What does it happen now if I pass -8 though the environmental variable to choose the drawable type?

Largely undefined behaviour, but from a first glance of the implementation you'll at least get some type of warning from the systemwindow.

@eile
Copy link
Member Author

eile commented Dec 21, 2016

All the config files that you have removed should be modified to use FBOs instead? Or you don't really want to keep them?

The removed once where PBuffer-specific. There are others which moved from PBuffer to FBO.

eile pushed a commit to eile/Equalizer that referenced this pull request Dec 21, 2016
CR Eyescale#602
ab448e2
@eile eile merged commit 48d2e37 into Eyescale:master Dec 22, 2016
eile added a commit to eile/Equalizer that referenced this pull request Feb 14, 2017
@eile
Remove PBuffer support (Eyescale#602)
cfca5f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hernando hernando hernando approved these changes

Assignees

@hernando hernando

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eile @hernando