Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configs with no running channels should exit or fail #304

Closed
tribal-tec opened this issue Feb 26, 2014 · 1 comment
Closed

Configs with no running channels should exit or fail #304

tribal-tec opened this issue Feb 26, 2014 · 1 comment
Labels
Milestone

Comments

@tribal-tec
Copy link
Member

If the config has only one single node which fails at configInit() for whatever reason, the config still reports 'Config init sucessful' and tries to render frames, which apparently cannot give any reasonable results:

30910 R PN2co9Loc qualizer/eq/client/config.cpp:1234 1066 Finished frame 0 was not locally unlocked, enforcing unlock
30910 R PN2co9Loc qualizer/eq/client/config.cpp:1234 1067 Finished frame 1 was not locally unlocked, enforcing unlock
.
.
.

This is the default behavior if IATTR_ROBUSTNESS is on or auto. Setting it to off gives the expected behavior.

Imo, even if with robustness set to on it should ensure to have at least one up and running node to continue rendering.

@eile eile added this to the 2.0 milestone Feb 26, 2014
@eile eile added the bug label Feb 26, 2014
@eile
Copy link
Member

eile commented Feb 26, 2014

Interesting problem - the same applies to runtime failures, i.e., as soon as nActiveChannels == 0 -> Config::isRunning() = false?

@eile eile changed the title configInit() and robustness tries to render with no running node Configs with no running channels should exit or fail Aug 15, 2014
@eile eile closed this as completed in a5a1f64 Aug 18, 2014
tribal-tec added a commit that referenced this issue Aug 18, 2014
tribal-tec added a commit to tribal-tec/Equalizer that referenced this issue Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants