Code

Feature: Onyx Cache#76

Code

Merged

marcaaron merged 40 commits intoExpensify:masterExpensify/react-native-onyx:masterfrom kidroca:kidroca/onyx-cachekidroca/react-native-onyx:kidroca/onyx-cacheCopy head branch name to clipboardJun 7, 2021

+1,067-124

Commits

Commits on May 25, 2021

• test: move metrics decoration tests to separate file

  kidroca

  committed
  a343ef1

  Copy full SHA for a343ef1

• test: move Onyx require call to beforeEach

  kidroca

  committed
  a7ee841

  Copy full SHA for a7ee841

• test: fix withOnyx test not returning promise

  kidroca

  committed
  d23b8eb

  Copy full SHA for d23b8eb

• test: add a test suite for Onyx cache

  kidroca

  committed
  a6df3db

  Copy full SHA for a6df3db

• feat: Add separate service for cache

  kidroca

  committed
  231fe00

  Copy full SHA for 231fe00

• test: add OnyxCache tests

  kidroca

  committed
  2f76d80

  Copy full SHA for 2f76d80

• feat: Use OnyxCache to cache storage operations

  kidroca

  committed
  1046786

  Copy full SHA for 1046786

• test: update Onyx with Cache to run correctly

  kidroca

  committed
  273afe1

  Copy full SHA for 273afe1

• refactor: cache.merge should throw when a value is not an object or array

  kidroca

  committed
  47739e4

  Copy full SHA for 47739e4

• refactor: extract prepareKeyValuePairsForStorage method

  Show description for f4a523f
  kidroca

  committed
  f4a523f

  Copy full SHA for f4a523f

• refactor: simplify mergeCollection keys partitioning

  kidroca

  committed
  6b659d7

  Copy full SHA for 6b659d7

• docs: add todo notes on withOnyx test not passing expected props to component

  kidroca

  committed
  f7feafc

  Copy full SHA for f7feafc

• fix: get should capture different tasks for different keys

  kidroca

  committed
  16d42ac

  Copy full SHA for 16d42ac

Commits on May 27, 2021

• fix: clear async storage

  kidroca

  committed
  5b11545

  Copy full SHA for 5b11545

• feat: enhance cache.merge to work with primitives as well as complex values

  kidroca

  committed
  0c51923

  Copy full SHA for 0c51923

• refactor: update hasCacheForKey to use isDefined

  kidroca

  committed
  22ad916

  Copy full SHA for 22ad916

• docs: cache.update try to better explain this method

  kidroca

  committed
  d0c62c5

  Copy full SHA for d0c62c5

• feat: clean up cache when the last key for a subscription is disconnected

  kidroca

  committed
  1b35161

  Copy full SHA for 1b35161

• refactor: encapsulate cache checking and resolving logic for getAllKeys in the cache service

  kidroca

  committed
  b33e696

  Copy full SHA for b33e696

• refactor: encapsulate cache checking and resolving logic for get in the cache service

  kidroca

  committed
  4af3abf

  Copy full SHA for 4af3abf

• Rename tests/decorateWithMetrics.js to tests/decorateWithMetricsTest.js

  kidroca

  committed
  ceb4acf

  Copy full SHA for ceb4acf

• test: check what happens with cache when async storage rejects

  kidroca

  committed
  5435063

  Copy full SHA for 5435063

• docs: update getAllKeys and getValue documentation

  kidroca

  committed
  dc2a540

  Copy full SHA for dc2a540

• test: Shorten test case names

  kidroca

  committed
  34cb2aa

  Copy full SHA for 34cb2aa

Commits on May 28, 2021

• refactor: handle cache cleanup for collections

  kidroca

  committed
  dfe362d

  Copy full SHA for dfe362d

• test: fix react warning that items don't have a key

  kidroca

  committed
  f14e5d7

  Copy full SHA for f14e5d7

• refactor: rename OnyxCache.update to OnyxCache.set

  kidroca

  committed
  2494a55

  Copy full SHA for 2494a55

• refactor: extract a separate addKey method

  kidroca

  committed
  ee177e2

  Copy full SHA for ee177e2

• fix: Onyx.multiSet should not use cache.merge, but cache.set to overwrite data

  kidroca

  committed
  55086b4

  Copy full SHA for 55086b4

Commits on Jun 1, 2021

• refactor: Update cache merge to work like AsyncStorage.merge and lodashMerge

  kidroca

  committed
  afd91ca

  Copy full SHA for afd91ca

• Revert "refactor: encapsulate cache checking and resolving logic for get in the cache service"

  Show description for 9231475
  kidroca

  committed
  9231475

  Copy full SHA for 9231475

• Revert "refactor: encapsulate cache checking and resolving logic for getAllKeys in the cache service"

  Show description for 4e57857
  kidroca

  committed
  4e57857

  Copy full SHA for 4e57857

• refactor: extract separate methods from resolveTask so usage in Onyx is more clear

  kidroca

  committed
  a27841d

  Copy full SHA for a27841d

• test: update tests related to task capturing after changes

  kidroca

  committed
  1ff60fc

  Copy full SHA for 1ff60fc

• convert async/await tests to promise based chains

  kidroca

  committed
  4eed726

  Copy full SHA for 4eed726

• docs: update comment

  kidroca

  committed
  7b35a24

  Copy full SHA for 7b35a24

Commits on Jun 2, 2021

• docs: Apply suggestions from code review

  Show description for d6f153c
  

  kidroca

  and

  roryabraham

  authored
  d6f153c

  Copy full SHA for d6f153c

• docs: Remove leftover method description

  kidroca

  authored
  27c0ba8

  Copy full SHA for 27c0ba8

• Skip creating an arrow function for AsyncStorage.clear

  Show description for 5254568
  

  kidroca

  and

  roryabraham

  authored
  5254568

  Copy full SHA for 5254568

Commits on Jun 3, 2021

• Explicitly convert set to array

  kidroca

  authored
  77b07e1

  Copy full SHA for 77b07e1