Code

Feature: Benchmark Onyx#70

Code

Merged

Gonals merged 55 commits intoExpensify:masterExpensify/react-native-onyx:masterfrom kidroca:kidroca/benchmarkkidroca/react-native-onyx:kidroca/benchmarkCopy head branch name to clipboardMay 25, 2021

+663-9

Commits

Commits on May 12, 2021

• Ignore IDE local hidden files

  kidroca

  committed
  2a44416

  Copy full SHA for 2a44416

• refactor: extract get to separate file for internal usage

  kidroca

  committed
  e1f5f0b

  Copy full SHA for e1f5f0b

• feat: decorateWithMetrics add the core decorator logic

  kidroca

  committed
  4b80fce

  Copy full SHA for 4b80fce

• test: decorateWithMetrics single methods tests

  kidroca

  committed
  2532c80

  Copy full SHA for 2532c80

• refactor: partially move set to Onyx.internal.js

  kidroca

  committed
  8011ea1

  Copy full SHA for 8011ea1

• refactor: add getAllKeys to Onyx.internal.js

  kidroca

  committed
  e4164b2

  Copy full SHA for e4164b2

• test: decorateWithMetrics test void methods

  kidroca

  committed
  724a67e

  Copy full SHA for 724a67e

• test: decorateWithMetrics verify original method return value is not affected

  kidroca

  committed
  743cdc7

  Copy full SHA for 743cdc7

• decorateWithMetrics throw on re-decorate, return all metrics

  kidroca

  committed
  097fbb3

  Copy full SHA for 097fbb3

• test: decorateWithMetrics multiple items tests

  kidroca

  committed
  dd78042

  Copy full SHA for dd78042

• refactor: extract decorateWithMetricsMultiple helper

  kidroca

  committed
  d961ece

  Copy full SHA for d961ece

• refactor: return Promise from merge

  kidroca

  committed
  5c27245

  Copy full SHA for 5c27245

• refactor: return Promise from addAllSafeEvictionKeysToRecentlyAccessedList

  kidroca

  committed
  602a1cc

  Copy full SHA for 602a1cc

• feat: Apply benchmarking stats tracking through an ENV variable

  kidroca

  committed
  350bc10

  Copy full SHA for 350bc10

Commits on May 13, 2021

• refactor: switch to captureMetrics flag to apply benchmarking

  Show description for 01bd076
  kidroca

  committed
  01bd076

  Copy full SHA for 01bd076

• test: decorateWithMetrics add more tests and cover more cases

  kidroca

  committed
  367df32

  Copy full SHA for 367df32

• refactor: store result in the call information as it preserves the tag

  kidroca

  committed
  2e1339f

  Copy full SHA for 2e1339f

Commits on May 14, 2021

• docs: Add more documentation regarding benchmarking

  kidroca

  committed
  32ca064

  Copy full SHA for 32ca064

• Revert addAllSafeEvictionKeysToRecentlyAccessedList

  Show description for f71fdd3
  kidroca

  committed
  f71fdd3

  Copy full SHA for f71fdd3

• refactor: address applyDecorators PR comments

  kidroca

  committed
  a5667c9

  Copy full SHA for a5667c9

• refactor: make decorateWithMetrics work with non promise methods as well

  kidroca

  committed
  316c803

  Copy full SHA for 316c803

• refactor: better accurate tracking for tagged items

  kidroca

  committed
  46f0a4d

  Copy full SHA for 46f0a4d

• refactor: Remove separate error property in call stats

  kidroca

  committed
  4cabc51

  Copy full SHA for 4cabc51

• test: update failing test

  kidroca

  committed
  69b447b

  Copy full SHA for 69b447b

• feat: allow aliasing methods to avoid collisions

  kidroca

  committed
  399f693

  Copy full SHA for 399f693

• refactor: replace map with plain object

  kidroca

  committed
  87068d0

  Copy full SHA for 87068d0

• test: aliasing the same method name in different instance should not throw

  kidroca

  committed
  6217a31

  Copy full SHA for 6217a31

• refactor: capture TaggedItem props for better retained size calculation

  kidroca

  committed
  5b66008

  Copy full SHA for 5b66008

• refactor: Update decorator to decorate function inline

  Show description for 879f443
  kidroca

  committed
  879f443

  Copy full SHA for 879f443

• Revert "refactor: add getAllKeys to Onyx.internal.js"

  Show description for 1123a0c
  kidroca

  committed
  1123a0c

  Copy full SHA for 1123a0c

• Revert "refactor: partially move set to Onyx.internal.js"

  Show description for 9145ef4
  kidroca

  committed
  9145ef4

  Copy full SHA for 9145ef4

• Revert "refactor: extract get to separate file for internal usage"

  Show description for 6de0139
  kidroca

  committed
  6de0139

  Copy full SHA for 6de0139

• refactor: reassign function in-place

  kidroca

  committed
  304584f

  Copy full SHA for 304584f

Commits on May 18, 2021

• test: decorateWithMetrics - docs GIVEN|WHEN|THEN

  kidroca

  committed
  76de920

  Copy full SHA for 76de920

• docs: decorateWithMetrics TaggedItem docs

  kidroca

  committed
  a0da959

  Copy full SHA for a0da959

• feat: store an alias on the TaggedItem so you can trace what created it

  kidroca

  committed
  614057a

  Copy full SHA for 614057a

• refactor: early return for resetMetrics

  kidroca

  committed
  51ba301

  Copy full SHA for 51ba301

• fix: provide correct methods for decoration

  kidroca

  committed
  19b972b

  Copy full SHA for 19b972b

Commits on May 21, 2021

• refactor: remove memory tracking with WeakMap

  kidroca

  committed
  1f1e6f0

  Copy full SHA for 1f1e6f0

• refactor: remove handling for non promise based functions

  Show description for 3b0c728
  kidroca

  committed
  3b0c728

  Copy full SHA for 3b0c728

• refactor: remove result from the captured stats

  kidroca

  committed
  2e6eec7

  Copy full SHA for 2e6eec7

• refactor: remove getting calls for only a specific method

  kidroca

  committed
  f582ddd

  Copy full SHA for f582ddd

• refactor: extract getAllKeys and replace usages

  kidroca

  committed
  7e8fc39

  Copy full SHA for 7e8fc39

• feat: add total and average time and print statistics functionality

  kidroca

  committed
  0dda698

  Copy full SHA for 0dda698

• feat: extended stats information with min, max, average for individual methods

  kidroca

  committed
  63c7f07

  Copy full SHA for 63c7f07

• refactor: separate print function and human readable duration

  kidroca

  committed
  eb7b109

  Copy full SHA for eb7b109

• refactor: better summary

  kidroca

  committed
  74a393c

  Copy full SHA for 74a393c

• docs: Update README information regarding benchmarking

  kidroca

  committed
  e9c8477

  Copy full SHA for e9c8477

• fix: human readable formatting

  kidroca

  committed
  74809be

  Copy full SHA for 74809be

• Merge remote-tracking branch 'E.cash/master' into kidroca/benchmark

  Show description for fff99e7
  kidroca

  committed
  fff99e7

  Copy full SHA for fff99e7

• docs: Add function documentation for applyDecorators

  kidroca

  committed
  cbab136

  Copy full SHA for cbab136

• fix: re-expose the decorated methods on the Onyx instance

  kidroca

  committed
  c3ae337

  Copy full SHA for c3ae337

Commits on May 24, 2021

• test: Add tests to verify exposed methods are decorated when they should be

  kidroca

  committed
  5fa1d73

  Copy full SHA for 5fa1d73

• docs: Fix getAllKeys return value

  kidroca

  committed
  cd4c986

  Copy full SHA for cd4c986

• docs: Remove typedef documentation for metrics

  kidroca

  committed
  b71e911

  Copy full SHA for b71e911