Fix multiSet when pairs is empty

[marcochavezf]

Details

The native apps are crashing because there's an action (unknown at the moment) that calls Onyx.multiSet with an empty object as argument. This happens because the query for multiSet is expecting an array with key-value pairs.

Additionally, this bug was reported here.

Related Issues

Expensify/App#14437

Automated Tests

N/A

Linked PRs

N/A atm, a new PR will be created when this change is deployed to npm

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[marcochavezf]

I have read the CLA Document and I hereby sign the CLA

[s77rt]

While you are fixing this, can you check other methods too? such as mergeCollection etc..

[mountiny]

@marcochavezf Have you been able to test this patch? Could you please upload a video of the sign-out on native working? The changes look good to me, but it would be good to confirm just now

[marcochavezf]

While you are fixing this, can you check other methods too? such as mergeCollection etc..

Good call, seems we're fine with other methods. For mergeCollection we're already checking here if the collection is empty.

[marcochavezf]

@marcochavezf Have you been able to test this patch? Could you please upload a video of the sign-out on native working? The changes look good to me, but it would be good to confirm just now

Yeap, sure I attach a video with the fix:

Screen.Recording.2023-01-20.at.17.21.35.mov

[marcochavezf]

Merging it now to fix the deploy blocker. Thanks @mountiny!

[mountiny]

thanks!