Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare react-native-onyx for TypeScript migration #260

Closed
hayata-suenaga opened this issue Jun 12, 2023 · 2 comments
Closed

Prepare react-native-onyx for TypeScript migration #260

hayata-suenaga opened this issue Jun 12, 2023 · 2 comments
Assignees
@neil-marcellini @hayata-suenaga
Labels
Daily Engineering NewFeature

Comments

@hayata-suenaga
Copy link
Contributor

hayata-suenaga commented Jun 12, 2023 •
edited
Loading

Part of the TypeScript migration issues.

  • Design doc
  • Remove expensify-common package.
    • Copy methods imported from expensify-commmon. There are only two functions imported. (Stack discussion)
  • Create type definition files for exported APIs
@hayata-suenaga hayata-suenaga self-assigned this Jun 12, 2023
@hayata-suenaga hayata-suenaga mentioned this issue Jun 12, 2023
Closed
20 tasks
@fabioh8010 fabioh8010 mentioned this issue Jun 27, 2023
Merged
@fabioh8010 fabioh8010 mentioned this issue Jul 18, 2023
Merged
@neil-marcellini neil-marcellini self-assigned this Aug 9, 2023
@neil-marcellini
Copy link
Contributor

I'm also assigning to get credit for all the time I put into the review.

@hayata-suenaga
Copy link
Contributor Author

The PR for creating type declaration files are merged and Onyx is ready to be used in App for migration. Closing this 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neil-marcellini neil-marcellini

@hayata-suenaga hayata-suenaga

Labels
Daily Engineering NewFeature
Projects
No open projects
Typescript migration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neil-marcellini @hayata-suenaga