fix: emoji anchor text with hyperlink #536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Emoji only is accepted as an anchor text and it doesn't look pleasing to the eye. We don't want emoji-only text to be anchor text for links.
Fixed Issues
$ Expensify/App#18386
PROPOSAL: Expensify/App#18386 (comment)
Tests
To test, we need to update the hash commit of expensify-common package in App repo into
0f363d1eb6731aac34c20a0102822557253ac6a4
like this:"expensify-common": "git+ssh://[email protected]/expensify/expensifycommon.git#0f363d1eb6731aac34c20a0102822557253ac6a4"
Open any chat and:
QA Steps
Open any chat and:
Screenshots/Videos
Web
Screen.Recording.2023-05-15.at.16.12.05.mp4
Mobile Web - Chrome
processed-5789CDCD-44B0-47A0-A4F1-66E9C06280D7-DD46FAA8-F954-4B0B-9263-0D3D6D2F6AC3.mp4
Mobile Web - Safari
processed-22203F0E-BFD9-4745-AF6F-6A18F5FAAF7A-8D8A193E-7357-4A28-B555-137A77C429CA.mp4
Desktop
Screen.Recording.2023-05-15.at.20.12.36.mp4
IOS
Screen.Recording.2023-05-15.at.16.08.40.mp4
Android
Screen.Recording.2023-05-15.at.22.06.05.mp4