Markdown issue resolved #461

jeet-dhandha · 2022-08-05T05:25:21Z

TAG_REVIEWER will you please review this?
@rushatgabhane @sketchydroide

[Explanation of the change or anything fishy that is going on]

There was no way to write ~~~~ in our current code block. After fixing the markdown issue user can now write ~~~~.

Fixed Issues

$ Expensify/App#9826

Tests

What unit/integration tests cover your change? What autoQA tests cover your change?

No changes are need to be done in this test.

What tests did you perform that validates your changed worked?

Tested with npm run test.

QA

What does QA need to do to validate your changes?

Go to any chat -> then try writing ~~~~ and send in message the text should remain same without any striked out text.

First message contains old code and unexpected output. And second message contains expected out which was sent with the fixed code.

What areas do they need to test for regressions?

QA need to test strikethrough text testing with different scenarios.
The developers can test using current npm run test.

github-actions · 2022-08-05T05:25:42Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jeet-dhandha · 2022-08-05T05:27:27Z

I have read the CLA Document and I hereby sign the CLA

rushatgabhane · 2022-08-05T07:07:58Z

@jeet-dhandha please copy and fill the PR template from https://github.com/Expensify/App/blob/main/.github/PULL_REQUEST_TEMPLATE.md

Thanks so much! 🙇

Justicea83 · 2022-08-05T17:06:34Z

requesting @sketchydroide for review because you're tagged

jeet-dhandha · 2022-08-05T20:54:10Z

Details

Fixed Issues

$ Expensify/App#9826

Tests

Click and open any chat.
Now try to send "~~~~" string which is in double quotes.

Expected output:

no changes should be done to the string after sending the message.

Current:

First "~" is strike through and second one without strikethrough.
Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Click and open any chat.
Now try to send "~~~~" string which is in double quotes.

Expected output:

no changes should be done to the string after sending the message.

Current:

First "~" is strike through and second one without strikethrough.
Verify that no errors appear in the JS console

Screenshots

Web

Screen.Recording.2022-08-07.at.10.05.59.PM.mov

Mobile Web

Screen.Recording.2022-08-07.at.10.12.04.PM.mov

Desktop

Screen.Recording.2022-08-07.at.10.09.28.PM.mov

iOS

Screen.Recording.2022-08-06.at.1.26.03.AM.mov

Android

Screen.Recording.2022-08-06.at.1.24.34.AM.mov

jeet-dhandha · 2022-08-05T20:55:55Z

Getting Issues on running "web"/"desktop":

jeet-dhandha · 2022-08-05T20:57:06Z

I have ran "yarn clean" and then tried running "npm ci" still no luck running without error

rushatgabhane · 2022-08-06T06:26:05Z

@jeet-dhandha please raise it on slack

jeet-dhandha · 2022-08-07T16:46:51Z

@rushatgabhane Added remaining videos now you can check 👍

rushatgabhane

@sketchydroide LGTM! 🎉

PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Justicea83

CHanges LGTM!

parasharrajat · 2023-09-20T09:45:21Z

lib/ExpensiMark.js

@@ -145,7 +145,7 @@ export default class ExpensiMark {
            },
            {
                name: 'strikethrough',
-                regex: /\B~((?!\s).*?\S)~\B(?![^<]*(<\/pre>|<\/code>|<\/a>))/g,
+                regex: /\B~((?=\S)((~~(?!~)|[^\s~]|\s(?!~))+?))~\B(?![^<]*(<\/pre>|<\/code>|<\/a>))/g,


This regex caused Expensify/App#25693

markdown issue resolved

d73e1af

jeet-dhandha requested a review from a team as a code owner August 5, 2022 05:25

melvin-bot bot requested review from Justicea83 and removed request for a team August 5, 2022 05:25

jeet-dhandha mentioned this pull request Aug 5, 2022

[$250] There is no way to write ~~~~ (without the code block) Expensify/App#9826

Closed

rushatgabhane approved these changes Aug 7, 2022

View reviewed changes

Justicea83 approved these changes Aug 8, 2022

View reviewed changes

sketchydroide approved these changes Aug 8, 2022

View reviewed changes

sketchydroide merged commit e0ec0b9 into Expensify:main Aug 8, 2022

neil-marcellini mentioned this pull request Aug 31, 2023

Update strikethrough replace rule to fix multiple tilde error #569

Merged

parasharrajat reviewed Sep 20, 2023

View reviewed changes

parasharrajat mentioned this pull request Sep 20, 2023

[PAID] [$1000] Markdown - ~~~hello~~~ is inconsistent with other markdown like ***hello*** Expensify/App#25693

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Markdown issue resolved #461

Markdown issue resolved #461

jeet-dhandha commented Aug 5, 2022

github-actions bot commented Aug 5, 2022 •

edited

Loading

jeet-dhandha commented Aug 5, 2022

rushatgabhane commented Aug 5, 2022

Justicea83 commented Aug 5, 2022

jeet-dhandha commented Aug 5, 2022 •

edited

Loading

PR Reviewer Checklist

jeet-dhandha commented Aug 5, 2022

jeet-dhandha commented Aug 5, 2022

rushatgabhane commented Aug 6, 2022

jeet-dhandha commented Aug 7, 2022

rushatgabhane left a comment •

edited

Loading

Justicea83 left a comment

parasharrajat Sep 20, 2023

Markdown issue resolved #461

Markdown issue resolved #461

Conversation

jeet-dhandha commented Aug 5, 2022

Fixed Issues

Tests

QA

github-actions bot commented Aug 5, 2022 • edited Loading

jeet-dhandha commented Aug 5, 2022

rushatgabhane commented Aug 5, 2022

Justicea83 commented Aug 5, 2022

jeet-dhandha commented Aug 5, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

jeet-dhandha commented Aug 5, 2022

Getting Issues on running "web"/"desktop":

jeet-dhandha commented Aug 5, 2022

rushatgabhane commented Aug 6, 2022

jeet-dhandha commented Aug 7, 2022

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Justicea83 left a comment

Choose a reason for hiding this comment

parasharrajat Sep 20, 2023

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2022 •

edited

Loading

jeet-dhandha commented Aug 5, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading