Add support for the paste and match style command #9880

marktoman · 2022-07-13T17:38:02Z

Details

Fixed Issues

$ #9240

Test Steps

Desktop (new functionality)

Steps

Select a submitted comment that has formatting in a chat
Press Cmd/Ctrl + C
Move to Composer and press Cmd/Ctrl + V
Delete it and press Cmd/Ctrl + Shift + V
Delete it and press Cmd/Ctrl + Shift + Option/Alt + V

Result
Input has formatting in 3. and loses it in 4 and 5.

Web, except Firefox (new functionality)

Steps

Right-click a submitted comment that has formatting in a chat
Click Copy to clipboard
Move to Composer, right-click, and select Paste
In Chrome, right-click or go to the Edit system menu, click Paste and Match Style. In Safari, this item is only in the Edit menu.
In Chrome, Delete it and press Cmd/Ctrl + Shift + V
In Chrome (mac) and Safari, Delete it and press Cmd + Shift + Option + V

Result
Input has formatting in 3. and loses it in 4-6.

Mobile web and Firefox (retaining existing functionality)

Steps

Long-tap (or right-click) on a submitted comment that has formatting in a chat
Tap Copy to clipboard
Move to Composer, long-tap (or right-click), pick Paste

Result
Input has formatting.

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

@Expensify/applauseleads please add this new functionality to the regression test suite

Desktop (new functionality)

Steps

Select a submitted comment that has formatting in a chat
Press Cmd/Ctrl + C
Move to Composer and press Cmd/Ctrl + V
Delete it and press Cmd/Ctrl + Shift + V
Delete it and press Cmd/Ctrl + Shift + Option/Alt + V

Result
Input has formatting in 3. and loses it in 4 and 5.

Web, except Firefox (new functionality)

Steps

Right-click a submitted comment that has formatting in a chat
Click Copy to clipboard
Move to Composer, right-click, and select Paste
In Chrome, right-click or go to the Edit system menu, click Paste and Match Style. In Safari, this item is only in the Edit menu.
In Chrome, Delete it and press Cmd/Ctrl + Shift + V
In Chrome (mac) and Safari, Delete it and press Cmd + Shift + Option + V

Result
Input has formatting in 3. and loses it in 4-6.

Mobile web and Firefox (retaining existing functionality)

Steps

Long-tap (or right-click) on a submitted comment that has formatting in a chat
Tap Copy to clipboard
Move to Composer, long-tap (or right-click), pick Paste

Result
Input has formatting.

Verify that no errors appear in the JS console

Screenshots

Web

mac-chrome.mp4

mac-safari.mp4

win-chrome.mp4

win-firefox.mp4

Mobile Web

android-chrome.mp4

android-firefox.mp4

ios-safari.mp4

Desktop

mac-desktop.mp4

iOS

ios-native.mp4

Android

android-native.mp4

desktop/main.js

src/libs/Clipboard/index.js

src/libs/Clipboard/index.native.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

src/libs/SelectionScraper/base.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

…paste

marktoman · 2022-07-16T11:07:15Z

There is one thing with the edit menu on desktop.

Currently, we have two Paste and Match style menu items under Edit in the system menu. One is provided by electron, which has a slightly different shortcut. Second we add ourselves. We have to have an item in the system menu for a keyboard shortcut to register. A context menu item with the shortcut is not enough.

What I have tried:

Pick the default item and change the shortcut. This does not work because the electron items are supplied after we submit ours (i.e. the arrays are empty).
Keep both items, but set ours with visible: false. This does not work for roles like paste and pasteAndMatchStyle. I assume the reason is security.

Options:

Keep both items
Remove ours and use the provided shortcut in the right-click context menu as well
Build the system menu from a template. The template would replace Menu.getApplicationMenu() with Menu.buildFromTemplate(template). The modifications below it that access the systemMenu variable remain the same. Inside the template, we simply add our shortcut: { role: 'pasteAndMatchStyle', accelerator: 'CmdOrCtrl+Shift+V' }. You can see the diff and test it as well.

parasharrajat · 2022-07-16T11:45:34Z

I have no clue about it so far. I will dig in and let you know. It would also be good to hear the pros of each option.

One is provided by electron, which has a slightly different shortcut.

What is different with native one?

marktoman · 2022-07-18T13:57:36Z

Electron provides us with the standard shortcut for paste and match style on mac (used in Text Edit, Safari, etc.), which includes alt.

We can decide to honor it because the input context menu makes the shortcut evident to the user.

The only change would be this in index.js:

contextMenu({
    append: (defaultActions, parameters) => [
        new MenuItem({
            visible: parameters.isEditable,
            role: 'pasteAndMatchStyle',
            accelerator: 'CmdOrCtrl+Alt+Shift+V',
        }),
    ],
});

Result:

marktoman · 2022-07-18T14:29:46Z

Keeping both items has the disadvantage of adding Paste and Match Style twice in the Edit menu, once for each shortcut. (This is not the case for the context menu.) It has the advantage of supporting both shortcuts.

Making cmd+shift+v default has the disadvantage of explicitly adding the menu template instead of leaving the default items to Electron.

Honoring the standard shortcut has the advantage of making the least amount of changes in index.js and adding no duplicit items to the Edit menu, and users expect this shortcut to work.

I think that because the context menu item makes the shortcut hard to miss, the shortcut itself is slightly less important.

parasharrajat · 2022-07-18T21:53:01Z

I will test this tomorrow. Thanks for the details.

marktoman · 2022-07-20T14:04:53Z

I've found that while chrome shows cmd+shift+v in the Edit menu (probably for parity with windows), it supports the standard mac shortcut as well. I think that from the mac user's point of view, cmd+shift+alt+v is essential while the other one is not.

parasharrajat · 2022-07-20T14:15:42Z

I am also in favor of using the system default. I wonder what is used for safari.

marktoman · 2022-07-20T14:18:57Z

Safari and other native mac apps use the standard. cmd+shift+v does not do anything in Safari.

parasharrajat · 2022-07-20T14:33:31Z

I will test it shortly and open a discussion about this on the issue to get a consensus for different shortcuts on MAC.

…paste

marktoman · 2022-07-22T12:01:58Z

Here it is in action:

mac-desktop.mp4

parasharrajat

I have suggested a few things that I feel are more reasonable. Feel free to discuss in case, you don't like any change. I am happy to get better ideas.

desktop/main.js

src/pages/settings/AppDownloadLinks.js

src/libs/SelectionScraper/BaseSelectionScraper.js

src/libs/SelectionScraper/index.js

src/libs/SelectionScraper/index.native.js

src/libs/Clipboard/index.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

src/libs/Clipboard/index.js

src/libs/Clipboard/index.native.js

src/libs/SelectionScraper/BaseSelectionScraper.js

src/libs/SelectionScraper/index.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

src/pages/home/report/ContextMenu/genericReportActionContextMenuPropTypes.js

desktop/main.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

marktoman · 2022-07-23T18:27:09Z

I have updated the description with a testing step for desktop and with the video showing all new desktop functionality.

src/pages/home/report/ContextMenu/ContextMenuUtils/index.native.js

src/pages/home/report/ContextMenu/genericReportActionContextMenuPropTypes.js

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

marktoman · 2022-07-25T18:46:10Z

I've updated the description with a video for Safari and fixed related steps.

parasharrajat

What do you think of the suggestions?

src/pages/home/report/ContextMenu/ContextMenuActions.js

src/libs/SelectionScraper/index.js

src/libs/SelectionScraper/index.native.js

src/pages/home/report/ContextMenu/ContextMenuActions.js

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

marktoman · 2022-07-29T16:28:26Z

@parasharrajat I've added your latest suggestions to this version. What do you think?

parasharrajat · 2022-07-29T17:03:01Z

Looking much better. let's try to revert the unnecessary changes.

src/libs/SelectionScraper/index.js

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

src/pages/home/report/ContextMenu/genericReportActionContextMenuPropTypes.js

parasharrajat

It's not working on Safari and firefox. I understand the reason for firefox but what about safari.

marktoman · 2022-08-01T12:04:42Z

It is working in Safari. Have you followed the steps?

parasharrajat

OK, looking good to me.

A few points about the PR.

We have implemented the native support for paste and match formatting instead of using Ctrl+Shift+V on all platforms. It may be technically impossible for some of the platforms to use a custom shortcut for such a feature. But most of the platform supports Ctrl+Shift+V for the same.

cc: @roryabraham

PR Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2022-08-01T13:15:24Z

@marktoman Please mention in the tests and QA steps that this does not work on Firefox Web. Also, Please add QA steps. If tests and QA steps are same copy paste them.

OSBotify · 2022-08-01T23:17:45Z

🚀 Deployed to staging by @roryabraham in version: 1.1.87-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

OSBotify · 2022-08-04T20:50:48Z

🚀 Deployed to production by @yuwenmemon in version: 1.1.87-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Add support for the paste and match style command

110057b

marktoman requested a review from a team as a code owner July 13, 2022 17:38

melvin-bot bot requested review from parasharrajat and roryabraham and removed request for a team July 13, 2022 17:38

parasharrajat suggested changes Jul 14, 2022

View reviewed changes

marktoman added 2 commits July 15, 2022 20:39

Generalize selection & clipboard, minor fixes

5731694

Merge branch 'main' of github.com:Expensify/App into 9240-clean-copy-…

d2840eb

…paste

parasharrajat mentioned this pull request Jul 20, 2022

[HOLD for payment 2022-08-11] [$2000] Feature request: Ability to paste text without auto formatting #9240

Closed

marktoman added 2 commits July 22, 2022 11:49

Merge branch 'main' of github.com:Expensify/App into 9240-clean-copy-…

4108ca4

…paste

Improve paste and match style menus on desktop

5ae0f7e

parasharrajat suggested changes Jul 22, 2022

View reviewed changes

Generalize clipboard & selection further, refactor

134a9a7

parasharrajat suggested changes Jul 23, 2022

View reviewed changes

desktop/main.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/ContextMenuActions.js Outdated Show resolved Hide resolved

Reduce selection, refactor

bb95f01

parasharrajat suggested changes Jul 23, 2022

View reviewed changes

Fix selection reset, refactor

8315bbb

marktoman requested a review from parasharrajat July 28, 2022 02:02

parasharrajat suggested changes Jul 28, 2022

View reviewed changes

marktoman added 2 commits July 29, 2022 16:32

Merge branch 'main' into 9240-clean-copy-paste

7450f1e

Make selection copy unrestrictive

01906b0

parasharrajat suggested changes Jul 29, 2022

View reviewed changes

src/libs/SelectionScraper/index.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js Outdated Show resolved Hide resolved

src/pages/home/report/ContextMenu/genericReportActionContextMenuPropTypes.js Outdated Show resolved Hide resolved

Fix comments & revert

7499f3d

parasharrajat suggested changes Aug 1, 2022

View reviewed changes

parasharrajat approved these changes Aug 1, 2022

View reviewed changes

roryabraham approved these changes Aug 1, 2022

View reviewed changes

roryabraham merged commit f654cc1 into Expensify:main Aug 1, 2022

OSBotify mentioned this pull request Aug 1, 2022

Deploy Checklist: New Expensify 2022-08-01 #10169

Closed

95 tasks

parasharrajat mentioned this pull request Aug 2, 2022

Copying formatted code is not working as expected #10189

Closed

b1tjoy mentioned this pull request Nov 10, 2022

[HOLD for payment 2022-12-20] [$2000] mweb - Copy & Paste - Copy & Pasting text form code editor is not consistent #10262

Closed

eVoloshchak mentioned this pull request May 1, 2023

[HOLD for payment 2023-04-28] [$1000] Double click to copy does not consider multiple formatting on text #17284

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for the paste and match style command #9880

Add support for the paste and match style command #9880

marktoman commented Jul 13, 2022 •

edited by roryabraham

Loading

marktoman commented Jul 16, 2022 •

edited

Loading

parasharrajat commented Jul 16, 2022 •

edited

Loading

marktoman commented Jul 18, 2022

marktoman commented Jul 18, 2022

parasharrajat commented Jul 18, 2022

marktoman commented Jul 20, 2022

parasharrajat commented Jul 20, 2022

marktoman commented Jul 20, 2022

parasharrajat commented Jul 20, 2022

marktoman commented Jul 22, 2022

parasharrajat left a comment

marktoman commented Jul 23, 2022

marktoman commented Jul 25, 2022

parasharrajat left a comment

marktoman commented Jul 29, 2022

parasharrajat commented Jul 29, 2022

parasharrajat left a comment

marktoman commented Aug 1, 2022

parasharrajat left a comment

parasharrajat commented Aug 1, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

Add support for the paste and match style command #9880

Add support for the paste and match style command #9880

Conversation

marktoman commented Jul 13, 2022 • edited by roryabraham Loading

Details

Fixed Issues

Test Steps

Desktop (new functionality)

Web, except Firefox (new functionality)

Mobile web and Firefox (retaining existing functionality)

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Desktop (new functionality)

Web, except Firefox (new functionality)

Mobile web and Firefox (retaining existing functionality)

Screenshots

Web

Mobile Web

Desktop

iOS

Android

marktoman commented Jul 16, 2022 • edited Loading

parasharrajat commented Jul 16, 2022 • edited Loading

marktoman commented Jul 18, 2022

marktoman commented Jul 18, 2022

parasharrajat commented Jul 18, 2022

marktoman commented Jul 20, 2022

parasharrajat commented Jul 20, 2022

marktoman commented Jul 20, 2022

parasharrajat commented Jul 20, 2022

marktoman commented Jul 22, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

marktoman commented Jul 23, 2022

marktoman commented Jul 25, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

marktoman commented Jul 29, 2022

parasharrajat commented Jul 29, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

marktoman commented Aug 1, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

PR Reviewer Checklist

parasharrajat commented Aug 1, 2022

OSBotify commented Aug 1, 2022

OSBotify commented Aug 4, 2022

marktoman commented Jul 13, 2022 •

edited by roryabraham

Loading

marktoman commented Jul 16, 2022 •

edited

Loading

parasharrajat commented Jul 16, 2022 •

edited

Loading