Re-fetch actions when we move from offline to online in IOUModal.js

[Justicea83]

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/208196

Tests

1. Sign into NewDot
2. Open a chat with anyone
3. Click on the + button close to the text input
4. Verify that a GET Command is sent with rvl GetLocalCurrency is made via Chrome Dev Tools network tab
5. Go offline
6. Come back online
7. Verify from the screenshot below

PR Reviewer Checklist

• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • iOS / native
  • Android / native
  • iOS / Safari
  • Android / Chrome
  • MacOS / Chrome
  • MacOS / Desktop
• I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
  • I verified any copy / text shown in the product was added in all src/languages/* files
  • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • Any functional components have the displayName property
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn’t already exist
  • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

• Verify that no errors appear in the JS console
• Sign into NewDot
• Open a chat with anyone
• Click on the + button close to the text input
• Verify that a GET Command is sent with rvl GetLocalCurrency is made via Chrome Dev Tools network tab
• Go offline
• Come back online
• Verify from the screenshot below

Screenshots

Web

2022-05-18_09-44-09.mp4

Mobile Web

2022-05-18_09-47-02.mp4

Desktop

2022-05-18_09-50-33.mp4

Android

android.mp4

[Justicea83]

cc: @marcaaron

[alex-mechler]

Please bring back the PR author checklist, as well as add screenshots showing you tested on each platform

[marcaaron]

Click on the + button close to the text input
Verify that a GET Command is sent with rvl GetLocalCurrency is made via Chrome Dev Tools network tab

I think we're missing a step here.

[alex-mechler]

Please add back the PR Author Checklist and also add screenshots showing you tested on each platform

[Justicea83]

Please bring back the PR author checklist, as well as add screenshots showing you tested on each platform

Hey @alex-mechler , please this is a sample PR, that didn't require testing on other platforms(#8817 and #8817), can you please take a look?

[alex-mechler]

I thought they were required for all PRs, asked in contributor management https://expensify.slack.com/archives/C01SKUP7QR0/p1652738900438809

[stitesExpensify]

Looks like this is linked to the wrong issue. Should be linked here https://github.com/Expensify/Expensify/issues/208196

[marcaaron]

Changes LGTM and test well

[Justicea83]

I thought they were required for all PRs, asked in contributor management https://expensify.slack.com/archives/C01SKUP7QR0/p1652738900438809

Yeah, they were, but this is a special case if you'll.

[stitesExpensify]

I don't think that I agree @Justicea83. You can still test this on all platforms except for iOS. Here's my PR for reference #8868. Even if you can't see the effects of the refresh, you can make sure that the component doesn't break on all platforms, and make sure that we don't get any weird flickering because of the data refresh

[alex-mechler]

I also don't agree that this is a special case. This is testable on every platform but iOS, and you can still check to ensure nothing has broken like Brandon mentioned.

[Justicea83]

Updated and awaiting another review

[OSBotify]

🚀 Deployed to staging by @alex-mechler in version: 1.1.63-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @AndrewGable in version: 1.1.63-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅