-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment on deploy checklist when a pull request is CP'd #7802
Conversation
This failure looks like it might be a bug in action-lint. Going to check it out more tomorrow. |
|
cc @mountiny in case you want to review as well since you've taken an interesting in our GitHub Actions. Don't want to hold on that because I know you're only working ~30% right now. |
Only added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the ping indeed, I am very happy to learn from how others will review it too. It is still interesting to me how much we can do through the actions.
I did not see any problems with the code and the unit tests probably show it works well. Can't say much about best practices yet.
Feel free to merge when e2e is done 👍 |
Triggered auto assignment to @luacmartins ( |
@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
(cherry picked from commit 9c75ded)
🚀 Cherry-picked to staging by @roryabraham in version: 1.1.39-3 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Not sure why it said it was merged without passing tests ... pretty sure I waited for tests to pass first 🤔 |
Got assigned QA, @roryabraham is there a proactive way of testing this or should I just monitor PRs that are merged with the |
I would say this works just fine per this comment that happened on the current checklist. |
Ah nice once @timszot! Yea, seems to be working as intended! |
Checking this off since it was already deployed in Feb! |
Details
Comments on the deploy checklist like so when a pull request is CP'd:
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.1.39-2
🚀Then waits for the staging deploy for that version to complete
then comments again like so:
🚀 All set?…You bet! https://github.com/Expensify/App/releases/tag/1.1.39-2 has been deployed to staging 🚀
Fixed Issues
$ #7178
Tests
Unit tests added.
QA Steps
CP Staging
label with the checklist locked.CP Staging
label with the checklist locked.