Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Separate report name and icon configuration from personal details" #7426

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

johnmlee101
Copy link
Contributor

Reverts #7367

this is causing #7417

@johnmlee101 johnmlee101 requested a review from a team as a code owner January 26, 2022 22:09
@johnmlee101 johnmlee101 self-assigned this Jan 26, 2022
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from chiragsalian and removed request for a team January 26, 2022 22:09
@johnmlee101
Copy link
Contributor Author

With revert
image

Before revert
image

@chiragsalian chiragsalian merged commit 38b99b1 into main Jan 26, 2022
@chiragsalian chiragsalian deleted the revert-7367-sn-bug_report_name_icon branch January 26, 2022 23:41
@chiragsalian
Copy link
Contributor

merged it, have to wait for it to be deployed on mobile before informing them to retest.

OSBotify pushed a commit that referenced this pull request Jan 26, 2022
…e_icon

Revert "Separate report name and icon configuration from personal details"

(cherry picked from commit 38b99b1)
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by @chiragsalian in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 1, 2022

🚀 Deployed to production by @roryabraham in version: 1.1.33-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants