Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes IOU - Unable to paste the amount copied from Notes on MacOS Safari #7219

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

songlang1994
Copy link
Contributor

@songlang1994 songlang1994 commented Jan 14, 2022

Details

Use TextInput directly imported from React Native in TextInputAutoWidthWithoutKeyboard. Because TextInputFocusable will transform styled text into markdown format when pasting. That's not what we want. See also: #6931 (comment)

Fixed Issues

$ #6931

Tests

  1. Copy a piece of bold text of amount number format. Some examples is in the following step 2:
  2. 12.50 or 1,234.8 or 0.5
  3. Verify they can be pasted into the amount input.

QA Steps

Same as above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web

Mobile Web

mobile-web

Desktop

desktop

iOS

ios

Android

ios

@songlang1994 songlang1994 requested a review from a team as a code owner January 14, 2022 08:34
@MelvinBot MelvinBot requested review from Julesssss and parasharrajat and removed request for a team January 14, 2022 08:34
@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@songlang1994
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@parasharrajat
Copy link
Member

Could you please add screenshots of all the platforms?

@songlang1994
Copy link
Contributor Author

Sure. I've added them just now.

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the styling so that it look the same as before.

Current Previous
image image

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @Julesssss

🎀 👀 🎀 C+ reviewed

Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well.

@Julesssss Julesssss merged commit 697717f into Expensify:main Jan 17, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Julesssss in version: 1.1.30-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.31-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants