Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed keyboard shortcuts hotkey #7162

Merged

Conversation

mananjadhav
Copy link
Collaborator

@mananjadhav mananjadhav commented Jan 12, 2022

Details

  • Changed the shortcut key for Keyboard Shortcuts modal

Fixed Issues

$ #6780

Tests

  1. Tested by opening modal via Keyboard shortcut 'Cmd + I'
  2. Tested in Firefox that the shortcut is overridden
  3. Tested the keyboard shortcut menu from desktop app
  • Verify that no errors appear in the JS console

QA Steps

  1. Navigate to the app
  2. Go to the homescreen
  3. Click on Cmd + I for macOS and Ctrl + I for Windows.
  4. It should open the Keyboard Shortcuts modal. The same shortcut should also be visible in the shortcuts modal.
  • Verify that no errors appear in the JS console

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-firefox-keyboard-shortcut.mov

Mobile Web

Desktop

desktop-keyboard-shortcut-menu-hotkey

desktop-keyboard-shortcut-hotkey_taivWZXy.mp4

iOS

Android

@mananjadhav mananjadhav requested a review from a team as a code owner January 12, 2022 18:13
@MelvinBot MelvinBot requested review from parasharrajat and puneetlath and removed request for a team January 12, 2022 18:13
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cc: @puneetlath

@puneetlath puneetlath merged commit 3c14145 into Expensify:main Jan 12, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @puneetlath in version: 1.1.29-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants