Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix broken ExpensifyText #7006

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[No QA] Fix broken ExpensifyText #7006

merged 1 commit into from
Jan 4, 2022

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Jan 4, 2022 •
edited
Loading

Fixed Issues

#6819 (comment)

Tests

  1. Build web app JS verify it works OK

QA Steps

No QA

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner January 4, 2022 02:43
@MelvinBot MelvinBot requested review from danieldoglas and removed request for a team January 4, 2022 02:43
@marcaaron marcaaron mentioned this pull request Jan 4, 2022
Merged
5 tasks
@marcaaron marcaaron self-assigned this Jan 4, 2022
@marcaaron marcaaron changed the title Fix broken ExpensifyText [No QA] Fix broken ExpensifyText Jan 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@anthony-hull anthony-hull mentioned this pull request Jan 4, 2022
Merged
5 tasks
@parasharrajat
Copy link
Member

parasharrajat commented Jan 4, 2022 •
edited
Loading

@mountiny Can we please merge this? this is holding some PRs.

@mountiny
Copy link
Contributor

mountiny commented Jan 4, 2022

@parasharrajat Let me have a look.

Julesssss
Julesssss approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks are passing and Web builds work as expected for me. Holding merge as I believe @mountiny is also reviewing.

mountiny
mountiny approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mainly looking through internal discussion of the failing deploys yesterday. I think Joe and Francois will look into the problems later today, and the only reason this was not merged last night was probably the E2E tests still running at the EOD.

@mountiny mountiny merged commit cb7f4a0 into main Jan 4, 2022
@mountiny mountiny deleted the marcaaron-fixExpensifyText branch January 4, 2022 12:33
@anthony-hull
Copy link
Contributor

thanks for the fast response 👍

@OSBotify OSBotify mentioned this pull request Jan 4, 2022
Closed
45 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2022

🚀 Deployed to staging by @mountiny in version: 1.1.24-22 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@Julesssss Julesssss mentioned this pull request Jan 4, 2022
Merged
1 task
@OSBotify
Copy link
Contributor

OSBotify commented Jan 5, 2022

🚀 Deployed to production by @francoisl in version: 1.1.25-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@Julesssss Julesssss Julesssss approved these changes

@mountiny mountiny mountiny approved these changes

@danieldoglas danieldoglas Awaiting requested review from danieldoglas

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marcaaron @parasharrajat @mountiny @anthony-hull @OSBotify @Jag96 @Julesssss