[NO QA] Planned improvements may not be paid out

[Beamanator]

cc @mallenexpensify @iwiznia

Details

We discussed internally and realized - if Expensify plans to implement a feature in the future and a contributor proposes implementing that feature in #expensify-open-source, Expensify shouldn't be obligated to pay out the reward, since we already had that idea in mind. Also noting that pretty much all features from Old Expensify are planned to be implemented in New Expensify.

Fixed Issues

N/A

Tests

N/A

QA Steps

N/A

[Beamanator]

Yo @nickmurray47 , this update is being discussed in Slack here, maybe wait a few days before merging in case someone has a suggestion?

[nickmurray47]

his update is being discussed in Slack here, maybe wait a few days before merging in case someone has a suggestion?

looks like no one has commented in the thread, so going to approve and merge

[OSBotify]

🚀 Deployed to staging by @nickmurray47 in version: 1.1.24-19 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

[OSBotify]

🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

[mallenexpensify]

What's the best way to share CONTRIBUTING.md updates in #expensify-open-source?
Would it be for one of the people assigned to the issue/PR update to drop a post in #expensify-open-source with what's changed? That way they're shared in a regular and timely manner. This way, they'd likely be included in the #expensify-open-source weekly update because the CM reviews posts in #expensify-open-source before posting the update

[iwiznia]

I don't think we need to share it anywhere, since GH already tells you whenever that file changes (IIRC when you submit a PR)

[mallenexpensify]

I think changes (at least significant ones or multiple ones) should be shared in #expensify-open-source otherwise the contributor won't know it's updated, right? We don't expect contributors to constantly revisit CONTRIBUTING.md for updates.

Maybe there's another/better way to do. cc @Beamanator, what do you think is best?

[Beamanator]

I thought we discussed somewhere, adding a section in the weekly #expensify-open-source update to check for "significant" updates to README.md, CONTRIBUTING.md, or CODE_OF_CONDUCT.md? I think that could be easy enough for the person to check & add to the update?

[iwiznia]

I am almost sure that GH will tell them and show them a message to check it out... isn't that good enough and harder to miss than a post in slack?

[mallenexpensify]

almost sure that GH will tell them and show them a message to check it out..

@iwiznia Where and/or how would they receive these?

check for "significant" updates to README.md, CONTRIBUTING.md, or CODE_OF_CONDUCT.md?

@Beamanator , what's the easiest/best way for a CM to find these?

[Beamanator]

what's the easiest/best way for a CM to find these?

@mallenexpensify There's pages for recent changes to those files (example for changes to CONTRIBUTING.md is this link) so CMs should be able to look at recent changes from that kind of link right? Do you think that kind of links is difficult to read / find updates? 🙃

[mallenexpensify]

Do you think that kind of links is difficult to read / find updates? 🙃

Why would anyone go there? Or, repeatedly check there then dig into each small update? I think it'd get a lot more eyes if we dropped into #expensify-open-source, either as one-off updates or as part of the weekly. If we're taking time to update the CONTRIBUTING.md, the updates are important and we want to contributors to know/read them vs them occasionally, maybe, going to here

ie.
I couple updates to CONTRIBUTING.md
ONE

Daily updates on weekdays are highly recommended. If you know you won’t be able to provide updates for > 1 week, please comment on the PR or issue how long you plan to be out so that we may plan accordingly. We understand everyone needs a little vacation here and there. Any issue that doesn't receive an update for 1 full week may be considered abandoned and the original contract terminated.

TWO

It’s possible that you found a bug or enhancement that we haven’t posted to the GitHub repository. This is an opportunity to propose a job, and (optionally) a solution. If it's a valid job proposal that we choose to implement by deploying it to production — either internally or via an external contributor — then we will compensate you $250 for identifying and proposing the improvement.

• Note: If you get assigned the job you proposed and you complete the job, this $250 for identifying the improvement is in addition to the reward you will be paid for completing the job. Please follow these steps to propose a job:
• Note about proposed improvements: Expensify has the right not to pay the $250 reward if the suggested improvement is already planned. Currently, Expensify plans to implement all features of the old Expensify app in New Expensify.

[Beamanator]

Oh maybe I wasn't clear with what I was proposing, here i was proposing we have CMs (or whoever writes the Weekly Updates) look for updates to CONTRIBUTING.md, README.md, CODE_OF_CONDUCT.md (using links like this) and add them to the weekly update, so those updates will get publicly displayed in #expensify-open-source weekly 🤔 Are we on the same page?

[iwiznia]

@iwiznia Where and/or how would they receive these?

I saw it, IIRC GH shows a pop up when you create a new PR after the contributing file is modified.

[Beamanator]

Here's what it looks like - the good thing is it shows updates to CONTRIBUTING.md & CODE_OF_CONDUCT.md, but bad thing is it doesn't show updates to README.md... I guess the most important updates / the updates we want contributors to be most aware of are in CONTRIBUTING and CODE_OF_CONDUCT though right?