Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resend button width #6958

Merged
merged 4 commits into from
Jan 14, 2022
Merged

fix resend button width #6958

merged 4 commits into from
Jan 14, 2022

Conversation

thesahindia
Copy link
Member

@thesahindia thesahindia commented Dec 30, 2021

Details

fixed the changing width of resend link button

Fixed Issues

$ #6893

Tests

QA Steps

  1. Go to login page
  2. Enter Email
  3. Choose forget password

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-15.at.2.38.33.AM.mov

Mobile Web

Screen.Recording.2022-01-15.at.2.37.34.AM.mov

Desktop

Screen.Recording.2022-01-15.at.2.39.47.AM.mov

iOS

Screen.Recording.2022-01-15.at.2.33.07.AM.mov

Android

Screen.Recording.2022-01-15.at.2.34.31.AM.mov

@thesahindia thesahindia requested a review from a team as a code owner December 30, 2021 19:09
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team December 30, 2021 19:09
@rushatgabhane
Copy link
Member

Nitpicking here.
The button resizes for Spanish lang.

Screencast.from.05-01-22.06-09-14.AM.+03.mp4

@stitesExpensify
Copy link
Contributor

Nitpicking here.
The button resizes for Spanish lang.

I don't think that's nitpicking, I think that's a great catch! Something a lot of people would miss

@thesahindia
Copy link
Member Author

For some weird reason the width is not changing after changing the language for the first time. It's working after reloading.

@stitesExpensify stitesExpensify merged commit 76b8718 into Expensify:main Jan 14, 2022
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @stitesExpensify in version: 1.1.29-11 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants