Enable Hermes JS Engine on Android #593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hermes JS Engine is supposed to make our Android app smaller and faster, this PR enables it!
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/142237
Tests
Started up the Android app and clicked around a bunch. Opened and closed the app a few times. Checked out the size difference of the app (About 20% smaller with Hermes). Tested the debugger. Everything seemed to work great!
I also updated the readMe to explain the new debugging.
I'm also going to send the following email: