-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar Image Upload Limit #5900
Merged
pecanoro
merged 14 commits into
Expensify:main
from
akshayasalvi:wkspace-image-size-limit
Oct 19, 2021
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1e74b9e
Updated params and config
akshayasalvi c28e73e
Added components for ConfirmModal along with state and prop chanes
akshayasalvi 4357ffc
Made translation dynamic and added isValidSize
akshayasalvi 754045f
Fixed label typos
akshayasalvi 921a577
Modified checks to show the error block and corrected translations
akshayasalvi 6d5f1fb
Added limit to the profile picture as well
akshayasalvi 601151a
Merge branch 'main' of github-personal:akshayasalvi/App into wkspace-…
akshayasalvi d9c7583
Fixed size param for native attachment picker
akshayasalvi 40efded
Added jsdoc comment for the function
akshayasalvi 9f8c0d9
Removed prop and converted calculations to bytes
akshayasalvi e288d0c
Change variable name for avatar max size
akshayasalvi 5fadd0a
Changed lodash to || for size var
akshayasalvi 470b3c3
Removed lodash.get ref
akshayasalvi 37fb1fc
Merge branch 'main' of github-personal:akshayasalvi/App into wkspace-…
akshayasalvi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we passing the size as a prop but then using the constant directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pecanoro
size
is for the size of the Avatar image - Large or default. Wasn't added in this PR. I just updated proptypes.and for upload size limit I had added props but based on the feedback removed, so using CONST directly.