Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix avatar doesn't go back to center after zoom #56733

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix avatar doesn't go back to center after zoom #56733

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee9be5e
fix gesture callbacks run on the js thread because of react-compiler
bernhardoj Feb 12, 2025
1187b39
lint
bernhardoj Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/MultiGestureCanvas/usePinchGesture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ const usePinchGesture = ({
.enabled(pinchEnabled)
// The first argument is not used, but must be defined
.onTouchesDown((_evt, state) => {
// react-compiler optimization unintentionally make all the callbacks run on the JS thread.
// Adding the worklet directive here will make all the callbacks run on UI thread back.

'worklet';

// We don't want to activate pinch gesture when we are swiping in the pager
if (!shouldDisableTransformationGestures.get()) {
return;
Expand Down