Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Cherry pick PR #56448 to staging 🍒 #56449

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

os-botify[bot]
Copy link

@os-botify os-botify bot commented Feb 6, 2025

🍒 Cherry pick #56448 to staging 🍒
This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:

```bash
git fetch
git checkout roryabraham-cherry-pick-staging-56448-1
git cherry-pick -S -x --mainline 1 6799d53211de1a8e3112c0ead58047d962972faf
```

Then manually resolve conflicts, and commit the change with `git cherry-pick --continue`. Lastly, please run:

```bash
git commit --amend -m "Update version to 9.0.94-16

(cherry picked from commit d9ba4e5)" -m "(CP triggered by roryabraham)"
```

That will help us keep track of who triggered this CP. Once all that's done, push your changes with `git push origin roryabraham-cherry-pick-staging-56448-1`, and then open this PR for review.

Note that you **must** test this PR, and both the author and reviewer checklist should be completed, just as if you were merging the PR to main.

(cherry picked from commit d9ba4e5)
@os-botify os-botify bot added the Engineering label Feb 6, 2025
@os-botify os-botify bot requested a review from a team as a code owner February 6, 2025 02:07
@os-botify os-botify bot added the Hourly KSv2 label Feb 6, 2025
@os-botify
Copy link
Author

os-botify bot commented Feb 6, 2025

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

Copy link

melvin-bot bot commented Feb 6, 2025

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team February 6, 2025 02:08
@@ -43,7 +43,7 @@ jobs:

- name: Set up git for OSBotify
id: setupGitForOSBotify
uses: ./.github/actions/composite/setupGitForOSBotifyApp
uses: Expensify/App/.github/actions/composite/setupGitForOSBotifyApp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing @

@roryabraham roryabraham merged commit 9fa0efd into staging Feb 6, 2025
4 of 6 checks passed
@roryabraham roryabraham deleted the roryabraham-cherry-pick-staging-56448-1 branch February 6, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants