Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add clickable custom emoji support for onboarding task" #56362

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

@carlosmiceli
Copy link
Contributor

Weird, didn't get the option to add a reviewer checklist so I went ahead and approved. Once the author's checklist is also complete maybe it gives me the option to add my checklist and review again?

@allgandalf
Copy link
Contributor

was assigned as C+ for the blocker #56356 (comment), does the revert need a C+ review?

@shubham1206agra
Copy link
Contributor

@allgandalf Straight revert so no review here

@roryabraham
Copy link
Contributor Author

straight revert, merging w/o checklists

@roryabraham roryabraham merged commit 2e9c10d into main Feb 4, 2025
14 of 17 checks passed
@roryabraham roryabraham deleted the revert-55222-clickable-emoji-in-expense-task branch February 4, 2025 19:13
Copy link

melvin-bot bot commented Feb 4, 2025

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Feb 4, 2025
@OSBotify
Copy link
Contributor

OSBotify commented Feb 4, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Feb 4, 2025
…-in-expense-task

Revert "Add clickable custom emoji support for onboarding task"

(cherry picked from commit 2e9c10d)

(CP triggered by roryabraham)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.0.94-4 🚀

platform result
🤖 android 🤖 cancelled 🔪
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Copy link
Contributor

github-actions bot commented Feb 6, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Copy link
Contributor

github-actions bot commented Feb 6, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging Emergency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants