[NoQA] Revert "[No QA] Install desktop node-modules only when building desktop app" #56271
+1
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewGable
approved these changes
Feb 3, 2025
melvin-bot
bot
requested review from
MarioExpensify
and removed request for
a team
|
@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mountiny
deleted the
revert-56161-jnowakow/install-desktop-node-modules-only-when-necessary
branch
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
mountiny
changed the title
|
Straight revert |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
87 tasks
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.94-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #56161
There are typescript and esLint issues with this PR