-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bank icon in header in Plaid flow #5621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @shawnborton just double-checking that all the styles look good. |
alex-mechler
suggested changes
Oct 1, 2021
Looks good to me! |
alex-mechler
approved these changes
Oct 4, 2021
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
13 tasks
🚀 Deployed to staging by @alex-mechler in version: 1.1.5-2 🚀
|
🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR adds the bank icon on the Plaid bank account selection page when the bank icon is available. When it isn't, we default to the generic bank icon.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/166782
Tests
From an account that has a workspace, but no cards set up:
Expensify Card
Get Started
Log into your bank
Continue
Chase
user_good
andpass_good
for credentialsContinue
Log into your bank
againContinue
Wells Fargo
user_good
andpass_good
for credentialsContinue
QA Steps
From an account that has a workspace, but no cards set up:
Expensify Card
Get Started
Log into your bank
Continue
Chase
user_good
andpass_good
for credentialsContinue
Log into your bank
againContinue
Wells Fargo
user_good
andpass_good
for credentialsContinue
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android