Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bank icon in header in Plaid flow #5621

Merged
merged 7 commits into from
Oct 4, 2021
Merged

Add bank icon in header in Plaid flow #5621

merged 7 commits into from
Oct 4, 2021

Conversation

puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Oct 1, 2021

Details

This PR adds the bank icon on the Plaid bank account selection page when the bank icon is available. When it isn't, we default to the generic bank icon.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/166782

Tests

From an account that has a workspace, but no cards set up:

  1. Click on profile image
  2. Click on workspace name to go to workspace settings
  3. Click Expensify Card
  4. Click Get Started
  5. Click Log into your bank
  6. Click Continue
  7. Choose Chase
  8. Enter user_good and pass_good for credentials
  9. Click Continue
  10. Land on account selection page and make sure Chase logo is showing before the text and size/alignment looks right
  11. Click back arrow
  12. Click Log into your bank again
  13. userClick Continue
  14. Choose Wells Fargo
  15. Enter user_good and pass_good for credentials
  16. Click Continue
  17. Land on account selection page and make sure default bank icon is showing before the text and size/alignment looks right

QA Steps

From an account that has a workspace, but no cards set up:

  1. Click on profile image
  2. Click on workspace name to go to workspace settings
  3. Click Expensify Card
  4. Click Get Started
  5. Click Log into your bank
  6. Click Continue
  7. Choose Chase
  8. Enter user_good and pass_good for credentials
  9. Click Continue
  10. Land on account selection page and make sure Chase logo is showing before the text and size/alignment looks right
  11. Click back arrow
  12. Click Log into your bank again
  13. userClick Continue
  14. Choose Wells Fargo
  15. Enter user_good and pass_good for credentials
  16. Click Continue
  17. Land on account selection page and make sure default bank icon is showing before the text and size/alignment looks right

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-09-30 at 5 59 28 PM

Screen Shot 2021-09-30 at 5 59 28 PM

Mobile Web

Screen Shot 2021-09-30 at 5 59 28 PM

Screen Shot 2021-09-30 at 5 59 28 PM

Desktop

Screen Shot 2021-09-30 at 5 59 28 PM

Screen Shot 2021-09-30 at 5 59 28 PM

iOS

Screen Shot 2021-09-30 at 5 59 28 PM

Screen Shot 2021-09-30 at 5 59 28 PM

Android

Screen Shot 2021-09-30 at 5 59 28 PM

Screen Shot 2021-09-30 at 5 59 28 PM

@puneetlath puneetlath self-assigned this Oct 1, 2021
@puneetlath puneetlath marked this pull request as ready for review October 1, 2021 18:27
@puneetlath puneetlath requested a review from a team as a code owner October 1, 2021 18:27
@puneetlath
Copy link
Contributor Author

cc @shawnborton just double-checking that all the styles look good.

@MelvinBot MelvinBot requested review from alex-mechler and removed request for a team October 1, 2021 18:28
@shawnborton
Copy link
Contributor

Looks good to me!

@alex-mechler alex-mechler merged commit 11cfb68 into main Oct 4, 2021
@alex-mechler alex-mechler deleted the puneet-bank-icons branch October 4, 2021 19:39
@OSBotify
Copy link
Contributor

OSBotify commented Oct 4, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2021

🚀 Deployed to staging by @alex-mechler in version: 1.1.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2021

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants