-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] [CP Staging] Disable the network going offline for now when a PONG is not received #56183
Conversation
Temporary, no-risk fix so not concerned with the ESlint checks or checklist. |
@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
See above |
[No QA] [CP Staging] Disable the network going offline for now when a PONG is not received (cherry picked from commit ec9a9ff) (CP triggered by tgolen)
🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.93-3 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.93-3 🚀
|
Explanation of Change
This PR will just disable the Network going offline for now
Fixed Issues
$ #56180
Tests
None
Offline tests
None
QA Steps
None
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop