Add PlusMinus icon and allow negative values in MoneyRequestAmountInput

[pasyukevich]

Explanation of Change

Fixed Issues

$ #53441
PROPOSAL:

Tests

1. Open the “Create Expense” screen.
2. Enter an amount and press “Flip”.
3. Verify that a minus sign appears before the currency.
4. Submit the expense.
5. Open the newly created expense.
6. Verify that the amount does not have a minus sign.
7. Tap on the amount and confirm that the minus sign appears before the currency.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. Open the “Create Expense” screen.
2. Enter an amount and press “Flip”.
3. Verify that a minus sign appears before the currency.
4. Submit the expense.
5. Open the newly created expense.
6. Verify that the amount does not have a minus sign.
7. Tap on the amount and confirm that the minus sign appears before the currency.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android-web-converted.webm

iOS: Native

ios-native-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

desktop-web-converted.mov

MacOS: Desktop

desktop-native-converted.mov

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[pasyukevich]

Android videos skipped for now - I have issues locally to build it
I will prepare it soon

[dannymcclain]

I'm assuming this PR is just for the big number pad/amount display, and that we'll handle displaying the negative amount in the push rows and previews elsewhere, is that correct?

[pasyukevich]

@dannymcclain Yes. At this PR I've prepared only the edit / create expense modal update

[dannymcclain]

Awesome, thanks for the confirmation!

The mobile positioning is looking great, but I wanted to check with @shawnborton about the positioning on desktop. I get why they're placed right above the button, but they feel a little low to me. 🤔

Also, @Expensify/design, do we want these buttons to have a min-width to make them a little more tappable on mobile? Or do y'all think they're ok as is?

[shawnborton]

I agree that we should give them a min-width.

Desktop is interesting... I almost wonder if we don't need the flip button because you can use the - key on your keyboard? So maybe we only would want a currency button, and I would think it would be closer to the amount input, like so?

But if we did keep the flip button (and maybe we should for consistency), maybe something like this makes sense:

[dannymcclain]

Cool—I do think we should keep the flip button on desktop, but I like your updated placement there.

I almost wonder if we don't need the flip button because you can use the - key on your keyboard?

Because of the way we're displaying the minus symbol (to the left of the currency) I'm actually not sure if you will be able to use the minus key 😬 because the minus isn't really part of the input. :run-away:

[shawnborton]

I'm actually not sure if you will be able to use the minus key 😬 because the minus isn't really part of the input.

Totally fair, I say we keep the button then - but let's see what @dubielzyk-expensify thinks too!

[dubielzyk-expensify]

Definitely agree on the min-width and the updated placement for desktop 👍

Because of the way we're displaying the minus symbol (to the left of the currency) I'm actually not sure if you will be able to use the minus key 😬 because the minus isn't really part of the input. :run-away:

Hmm. That's fair I guess, but wouldn't we just detect the - key being pressed and flip it for them? So yes the minus doesn't technically get inserted into the field, but rather that it just clicks an invisible flip button when they tap the - button? I think it'd be weird to not respect the minus button on the keyboard

[shawnborton]

Yeah, that was my initial thinking as well... might as well respect it since it's available to the user to press via the keyboard.

[dubielzyk-expensify]

Yep. And I'm in favor of removing the flip button itself on desktop then, though if you both like if for extra visibility I don't feel super strongly about that part specifically

[dannymcclain]

Ah that's a great point Jon! I hadn't thought of that. I still kinda like keeping the button on desktop though 🫣 but if you both feel strongly you DON'T want it, it's not something I'm going to lose sleep over.

[ZhenjaHorbach]

As far as I understand, we decided not to leave - button and make currency button next to the input on desktop
And in the case of mobile everything is good !
Right ?
Sorry if I'm wrong 😄

[pasyukevich]

as far as I understand, we agreed before to have the flip only 🙂

[pasyukevich]

But in case of removal of it for desktop, I have a question:

Since we have "-" as a symbol and want to remove it on the desktop, what is the expected behavior to remove the minus sign?

It wouldn't be possible to remove it with backspace or edit it directly

[shawnborton]

Why not? I would think hitting the backspace enough times would just remove the - sign - the same as if you had typed it out into a text field. It would just be the last thing to be deleted.

[dannymcclain]

Yeah that's one of the reasons I was in favor of keeping the flip button on desktop. Just having a hard time wrapping my mind around how it would work with just the keyboard input. @Expensify/design do you have ideas around the preferred behavior for adding and removing the - on desktop (without using the flip button)?

[shawnborton]

I just commented above but I don't see why we couldn't just use the backspace to get rid of the minus sign, as if you were typing into a text box.

[pasyukevich]

@shawnborton We currently have the next structure -

{minus sign}
{currency }
{text input}

Do you mean that the "-" sign should be removed only in case when we have 0 and press backspace one more time?

[pasyukevich]

[shawnborton]

Yes, that's exactly what I mean.

[pasyukevich]

And in the case of "-" press - we don't care where the cursor was, right?
What should happen if the user presses "-" one more time? (or "+")

[shawnborton]

I feel like you should only be able to press - at the beginning of the input, otherwise it wouldn't make sense to allow the user to input a number like 6-6

[pasyukevich]

Got it!

Should we also support this on mobile devices with the keyboard?

[shawnborton]

Mobile devices wouldn't use a native keyboard, they would use our custom big number pad.

[pasyukevich]

I meant the physical one. I recall we had some issues with them before.

[shawnborton]

Hmm I am not following, mind restating? Mobile shouldn't run into this issue because it would be forced to use the big number pad with buttons. There's no way to freely enter a minus sign via a native keyboard on mobile.