-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "Top bar for outstanding tab refuses to disappear when no transactions are found. " #56052
Conversation
…sactions are found. "
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Straight revert. |
[CP Staging] Revert "Top bar for outstanding tab refuses to disappear when no transactions are found. " (cherry picked from commit 1b039f6) (CP triggered by mountiny)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.92-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.92-6 🚀
|
Reverts #55329
Fixes:
$ #56029
And reintroduces #54731 which is NAB
QA Steps
Verify that the blocker doesn't occur again.